Last modified: 2013-06-05 21:19:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51034, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49034 - Piping used unnecessarily when modifying an existing link
Piping used unnecessarily when modifying an existing link
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-01 03:19 UTC by Matthew Flaschen
Modified: 2013-06-05 21:19 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-06-01 03:19:07 UTC
I edited https://en.wikipedia.org/w/index.php?title=Eagle_Lake_%28Florida%29&oldid=557775556 which contained a piped link:

[[Eagle Lake, Florida|Eagle Lake]]

I used VisualEditor to change the anchor text to Eagle Lake, Florida.  That means piping is no longer necessary.  However, on the review changes screen, it showed:

'''Eagle Lake''' is an elongated lake in shape located in the northern portion of [[Eagle Lake, Florida|Eagle Lake, Florida]].

(irrelevant parts after omitted).

It should just be:

[[Eagle Lake, Florida]]
Comment 1 ssastry 2013-06-03 21:27:43 UTC
Bug in LinkHandler in the serializer.  Our html2wt tests are lacking.

[subbu@earth lib] cat /tmp/x
<a rel='mw:WikiLink' href='./Foo' data-parsoid='{"a":{"href":"./Foo"},"sa":{"href":"Foo"},"stx":"simple"}'>Foo</a>
<a rel="mw:WikiLink" href="./Foo" data-parsoid='{"a":{"href":"./Foo"},"sa":{"href":"Foo"},"stx":"piped"}'>Foo</a>
[subbu@earth lib] node parse --html2wt < /tmp/x
[[Foo]]
[[Foo|Foo]]
Comment 2 ssastry 2013-06-03 21:39:40 UTC
Never mind ... bad test case.  This behavior is correct since the second html snippet corresponds to parse output of "[[Foo|Foo]]" as wikitext input.

The problem seems to be that the serializer doesn't exploit the information that the link target has been modified and that there is a diff-marker on the a-tag.
Comment 3 Gerrit Notification Bot 2013-06-03 22:10:38 UTC
Related URL: https://gerrit.wikimedia.org/r/66880 (Gerrit Change I6abef05522192f667d483b4eb4e05de771496c28)
Comment 4 Gerrit Notification Bot 2013-06-05 21:18:14 UTC
https://gerrit.wikimedia.org/r/66880 (Gerrit Change I6abef05522192f667d483b4eb4e05de771496c28) | change APPROVED and MERGED [by jenkins-bot]
Comment 5 ssastry 2013-06-05 21:19:42 UTC
Please note that this will be fixed on en-wp only after the latest version of parsoid is deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links