Last modified: 2014-09-29 20:44:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51074, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49074 - CSSJanus: border-radius is incorrectly interpreted as top-right-bottom-left
CSSJanus: border-radius is incorrectly interpreted as top-right-bottom-left
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: 1.22.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-03 07:50 UTC by Niklas Laxström
Modified: 2014-09-29 20:44 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2013-06-03 07:50:39 UTC 
> echo CSSJanus::transform( 'border-radius: 0px 0px 5px 5px' );
border-radius: 0px 5px 5px 0px

https://developer.mozilla.org/en-US/docs/Web/CSS/border-radius says:

border-radius: top-left top-right bottom-right bottom-left 

So bottom-left suddenly changes to top-right, which is incorrect. Noticed this in ULS.
Comment 1 Gerrit Notification Bot 2013-06-03 07:56:53 UTC 
Related URL: https://gerrit.wikimedia.org/r/66381 (Gerrit Change I411ea2cda0fcfc0c3182189ed6dc2f25851cd04c)
Comment 2 Bartosz Dziewoński 2013-06-03 10:44:47 UTC 
See also bug 45677 (which has a patch pending).
Comment 3 Krinkle 2013-06-03 19:43:24 UTC 
Neither Niklas' patch nor I97ee7431e1a5acb (from bug 45677) addresses the issue with border-radius.

border-radius is already being flipped but incorrectly. It need to be changed from:
top-left-bottom-right
to:
top-left top-right bottom-right bottom-left

Or, in Janus:

from: (x1-LEFT-x2-RIGHT)
to: (LEFT-RIGHT)-(LEFT-RIGHT)
Comment 4 Gerrit Notification Bot 2013-06-04 13:08:25 UTC 
https://gerrit.wikimedia.org/r/66381 (Gerrit Change I411ea2cda0fcfc0c3182189ed6dc2f25851cd04c) | change APPROVED and MERGED [by jenkins-bot]
Comment 5 Bartosz Dziewoński 2013-06-06 15:40:27 UTC 
I'll submit a core patch soon.
Comment 6 Bartosz Dziewoński 2013-06-06 16:06:32 UTC 
I22bc777b is the core patch, Iac9e78b8 is a revert of the workaround in ULS.
Comment 7 Gerrit Notification Bot 2013-07-17 10:52:46 UTC 
Change 67264 merged by jenkins-bot:
CSSJanus: Handle values of border-radius correctly

https://gerrit.wikimedia.org/r/67264
Comment 8 Gerrit Notification Bot 2014-09-29 20:21:45 UTC 
Change 67265 merged by jenkins-bot:
Revert "Workaround for border-radius due to bug 49074"

https://gerrit.wikimedia.org/r/67265
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links