Last modified: 2014-10-17 11:41:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51116, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49116 - Footer copyright notice should be displayed in user language rather than content language
Footer copyright notice should be displayed in user language rather than cont...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-04 13:18 UTC by Amir Ladsgroup
Modified: 2014-10-17 11:41 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir Ladsgroup 2013-06-04 13:18:52 UTC
We set up a global wiki for testing things in a RTL environment you can see it in [1]

We set our wiki language dv (for some reasons) In every language you see
copyright note in dv ("ހުރިހާ މާއްދާއެއް Creative Commons Attribution Share
Alike ގެ ދަށުން ލިބެން އެބަހުއްޓެވެ.")

[1] http://tools.wmflabs.org/wikitest-rtl/w/
Comment 1 Nemo 2013-06-04 13:33:18 UTC
How do you know it's ULS? Footer respects interface language on Meta.
Comment 2 Amir Ladsgroup 2013-06-04 13:59:08 UTC
It is part of interface and interface of the wiki changes with every language. Sorry for making it in wrong part.
Comment 3 Andre Klapper 2013-06-05 13:55:54 UTC
So what exactly is the bug described here?
What is the actual outcome, and what is the expected outcome?
Comment 4 Amir Ladsgroup 2013-06-05 15:07:04 UTC
My expected outcome is everyone with every language they choose, see the copyright note in their own language (copyright note must be set with language of interface). I mean when I see this wiki in English language the copyright note (like other parts of interface) must be in English not in dv
Comment 5 Amir E. Aharoni 2013-06-07 18:21:26 UTC
It is a core MediaWiki issue. By default MediaWiki shows the copyright notice in the content language.

In Wikidata, for example, it's customized using the extension WikimediaMessages.
Comment 6 Ryan Kaldari 2014-03-24 21:59:46 UTC
I agree that Skin::getCopyright() should be changed so that it returns the copyright notice in the user language rather than in the content language. All other parts of the footer (and chrome) are displayed in the user language.
Comment 7 Ryan Kaldari 2014-03-24 22:06:43 UTC
Now I remember why it works this way...

The name of the license is stored in the site config as plain text, not an i18n string. So the name of the license can't be localized. Since it would be weird to switch languages in the middle of the copyright notice, we just render the entire notice in the content language. (Note that this doesn't necessarily apply to WMF wikis that use the WikimediaMessages extension.)

In order to fix this bug, we would need to change how our licensing text is set.
Comment 8 Ryan Kaldari 2014-03-24 22:20:28 UTC
Hmm, looks like we use the user language anyway in the licensing notice on the edit page:
"Por favor observa que todas las contribuciones a Wikipedia se consideran hechas públicas bajo la Creative Commons Attribution..."

I guess we should go ahead and change Skin::getCopyright() to be consistent, even if it is slightly awkward. At least it will be more likely that a reader/reuser will actually be able to understand the copyright notice.
Comment 9 Gerrit Notification Bot 2014-03-24 23:05:09 UTC
Change 120696 had a related patch set uploaded by Kaldari:
Always render copyright notice in user language

https://gerrit.wikimedia.org/r/120696
Comment 10 Nemo 2014-03-25 07:30:25 UTC
(In reply to Ryan Kaldari from comment #8)
> Hmm, looks like we use the user language anyway in the licensing notice on
> the edit page:
> "Por favor observa que todas las contribuciones a Wikipedia se consideran
> hechas públicas bajo la Creative Commons Attribution..."

That specific wording comes from WikimediaMessages though.
Comment 11 Gerrit Notification Bot 2014-05-17 00:30:36 UTC
Change 120696 merged by jenkins-bot:
Always render copyright notice in user language

https://gerrit.wikimedia.org/r/120696
Comment 12 Nemo 2014-05-17 07:39:23 UTC
The patch is rather straightforward, this bug looks fixed. We can assess side effects later.
Comment 13 Gerrit Notification Bot 2014-08-21 17:50:31 UTC
Change 155590 had a related patch set uploaded by Kaldari:
Display footer copyright notice in user language on mobile

https://gerrit.wikimedia.org/r/155590
Comment 14 Gerrit Notification Bot 2014-08-21 22:14:11 UTC
Change 155590 merged by jenkins-bot:
Display footer copyright notice in user language on mobile

https://gerrit.wikimedia.org/r/155590
Comment 15 Andre Klapper 2014-10-17 11:41:31 UTC
(In reply to Gerrit Notification Bot from comment #14)
> Change 155590 merged by jenkins-bot:
> Display footer copyright notice in user language on mobile
> 
> https://gerrit.wikimedia.org/r/155590


Patch was merged - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links