Last modified: 2013-12-19 19:51:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51117, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49117 - GitInfo.php doesn't like brackets. Gives warning on Special:version
GitInfo.php doesn't like brackets. Gives warning on Special:version
Status: NEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.22.0
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-04 13:26 UTC by Bawolff (Brian Wolff)
Modified: 2013-12-19 19:51 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bawolff (Brian Wolff) 2013-06-04 13:26:46 UTC 
From Special:version:

<br />
<b>Warning</b>:  syntax error, unexpected ')' in /var/www/w/git/.git/config on line 17
 in <b>/var/www/w/git/includes/GitInfo.php</b> on line <b>173</b><br />
<br />
<b>Warning</b>:  Invalid argument supplied for foreach() in <b>/var/www/w/git/includes/GitInfo.php</b> on line <b>180</b><br />


-----

Relevant lines of my .git/config:


[merge "mediawikireleasenotes"]
        name = MediaWiki release notes merge driver
        driver = ruby $(git rev-parse --git-dir)/mediawikireleasenotes.rb %O %A %B

(The driver line is what is triggering the error)
Comment 1 Bartosz Dziewoński 2013-06-04 18:03:44 UTC 
GitInfo uses PHP's parse_ini_file() to parse git's config file, and that file is not an .ini file (even if it's pretty close). I think the exact format is documented in git's manpages, if we want to implement it fully instead of just suppressing the error.
Comment 2 spage 2013-12-19 19:51:55 UTC 
Reusing parse_ini_file() to parse git config also leads to bug 39825.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links