Last modified: 2014-03-17 02:05:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51147, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49147 - VisualEditor: "Review your changes" - cancel-arrow needs a tooltip; possibly replace with an "X"?
VisualEditor: "Review your changes" - cancel-arrow needs a tooltip; possibly ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
: easy
: 49983 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-04 18:52 UTC by Quiddity
Modified: 2014-03-17 02:05 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Arrow shown in top-right, under search bar (9.84 KB, image/png)
2013-06-04 18:52 UTC, Quiddity
Details
"Review your changes" - cancel-arrow needs a tooltip; possibly replace with an "X"? (56.56 KB, image/png)
2014-03-15 16:42 UTC, santosh reddy
Details

Description Quiddity 2013-06-04 18:52:50 UTC
Created attachment 12460 [details]
Arrow shown in top-right, under search bar

The Up-Arrow icon, at the top-right of the "Review your changes" dialog (which cancels the review window) needs a tooltip. 

I suggest: "Cancel review, go back to current edit" or similar.
Comment 1 Quiddity 2013-06-06 00:51:36 UTC
There's an Identical problem with the "Report a problem" dialog, in two places. 

1) The left-arrow at the left-hand-side needs a tooltip. "Cancel report, go back to Review" or similar.

2) The up-arrow at the top-right needs a different tooltip. "Cancel report, go back to current edit" or similar.

(I'm not sure if you'd prefer this in the same bug, or split into 2 bugs, or even 3 bugs. Please let me know.)
Comment 2 James Forrester 2013-06-06 17:28:56 UTC
Thanks for the catch!
Comment 3 Quiddity 2013-06-09 19:27:05 UTC
Someone else commented on this today, and suggested that an [X] might be a better icon than a < or ^.

See http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Link_pop-up for further discussion.
Comment 4 James Forrester 2013-06-21 23:38:21 UTC
*** Bug 49983 has been marked as a duplicate of this bug. ***
Comment 5 Ryan Kaldari 2013-06-21 23:41:10 UTC
Also needed in "Save your changes" dialog for up and left arrows.
Comment 6 James Forrester 2013-06-21 23:42:07 UTC
Argh, yes, Kaldari got his comment in before mine. :-)
Comment 7 santosh reddy 2014-03-15 13:22:30 UTC
I see that this bug has been cleared. Please check the bug and close this bug.
Comment 8 Andre Klapper 2014-03-15 16:23:58 UTC
santosh reddy: I have no idea what you meant by "cleared". This bug report is still open and there is no patch mentioned. In case you meant that the bug is fixed for you, please provide a clear link where you see it fixed. Thanks.
Comment 9 santosh reddy 2014-03-15 16:42:02 UTC
Created attachment 14829 [details]
"Review your changes" - cancel-arrow needs a tooltip; possibly replace with an "X"?

Look at the attached image,looks like this bug has been already solved. Arrow is replaced by an 'X'.
Comment 10 Quiddity 2014-03-15 19:07:19 UTC
All left-arrows (except for the link-dialog?) appear to have been replaced with "X", and all "X"s (plus the link-dialog arrow) have tooltips. 

I think this can be closed-as-fixed, but I will leave it up to the product team in case I missed something that they're tracking with this.
Comment 11 James Forrester 2014-03-17 02:05:40 UTC
Yes, this was fixed ages ago. Apologies for not noting and closing then – thanks for the reminder!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links