Last modified: 2013-10-10 13:09:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51158, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49158 - Remove secret.yml file
Remove secret.yml file
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Jeff Hall
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-04 22:14 UTC by Željko Filipin
Modified: 2013-10-10 13:09 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Željko Filipin 2013-06-04 22:14:43 UTC
Move contents to environment variables. Variables that should be created are mediawiki_password, saucelabs_key and saucelabs_username.

Jenkins already has SAUCE_ONDEMAND_ACCESS_KEY and SAUCE_ONDEMAND_USERNAME variables defined at https://wmf.ci.cloudbees.com/configure
Comment 1 Jeff Hall 2013-08-16 20:49:15 UTC
Fix for defining mediawiki_password as an environment variable:

https://github.com/wikimedia/qa-browsertests/pull/9

If that fix is accepted, I'll do an additional fix to address the remaining tasks in this bug (saucelabs_key and saucelabs_username).
Comment 2 Željko Filipin 2013-08-29 11:43:24 UTC
Jeff, apologies for the late reply, I was traveling. I have left a couple of comments on the pull request. Please let me know if you need help or if you have any questions.
Comment 3 Jeff Hall 2013-08-29 19:10:16 UTC
Thanks Željko.  That's a great suggestion about outputting a warning if the MEDIAWIKI_PASSWORD variable is not set, and I'll go ahead and work on that next!
Comment 4 Željko Filipin 2013-08-30 10:32:21 UTC
Yuvi, any news on gerrit-github script? We need to merge code from github! :)
Comment 5 Gerrit Notification Bot 2013-08-30 13:52:05 UTC
Change 81927 had a related patch set uploaded by Yuvipanda:
Move mediawiki_password from secret.yml to an environment variable.

https://gerrit.wikimedia.org/r/81927
Comment 6 Gerrit Notification Bot 2013-08-30 14:05:53 UTC
Change 79793 had a related patch set uploaded by Zfilipin:
Environment variabled determine where the test run

https://gerrit.wikimedia.org/r/79793
Comment 7 Gerrit Notification Bot 2013-08-30 17:16:09 UTC
Change 79793 merged by Cmcmahon:
Environment variabled determine where the test run

https://gerrit.wikimedia.org/r/79793
Comment 8 Gerrit Notification Bot 2013-08-30 21:22:42 UTC
Change 82046 had a related patch set uploaded by Zfilipin:
Renamed :cloudbees environment to :saucelabs. Removed ENVIRONMENT environment variable from Jenkins.

https://gerrit.wikimedia.org/r/82046
Comment 9 Gerrit Notification Bot 2013-08-30 21:52:11 UTC
Change 82049 had a related patch set uploaded by Zfilipin:
Documented how to set up required environment variables

https://gerrit.wikimedia.org/r/82049
Comment 10 Gerrit Notification Bot 2013-08-31 22:13:45 UTC
Change 82046 merged by Cmcmahon:
Renamed :cloudbees environment to :saucelabs. Removed ENVIRONMENT environment variable from Jenkins.

https://gerrit.wikimedia.org/r/82046
Comment 11 Gerrit Notification Bot 2013-08-31 22:16:11 UTC
Change 81927 merged by Cmcmahon:
Move mediawiki_password from secret.yml to an environment variable.

https://gerrit.wikimedia.org/r/81927
Comment 12 Gerrit Notification Bot 2013-09-19 19:59:56 UTC
Change 82049 merged by Cmcmahon:
Documented how to set up required environment variables

https://gerrit.wikimedia.org/r/82049

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links