Last modified: 2013-08-20 00:43:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51199, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49199 - Add index type_action
Add index type_action
Status: NEW
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Sean Pringle
:
Depends on:
Blocks: 46713 49188 52918
  Show dependency treegraph
 
Reported: 2013-06-05 17:29 UTC by Greg Grossmeier
Modified: 2013-08-20 00:43 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Greg Grossmeier 2013-06-05 17:29:11 UTC
Schema Change:

All wikis
tables: logging
changes: Add index type_action 
commit status: pending review

gerrit change Ic5a83c2f (maintenance/archives/patch-logging-type-action-index.sql)
Comment 1 Sean Pringle 2013-07-29 05:29:21 UTC
The gerrit link seems wrong?

The index name has no log* prefix while other newer indexes on the table do. Do we definitely want it applied as-is?
Comment 2 Greg Grossmeier 2013-07-29 19:52:43 UTC
Adding in Matthias and Brad for their thoughts (as they are other reviewers on that gerrit change).

btw, to see what I copied from, this is where things were tracked before: 
https://wikitech.wikimedia.org/w/index.php?title=Schema_changes&oldid=72637 (that's an old version of the page).
Comment 3 Brad Jorsch 2013-07-30 16:51:23 UTC
That Gerrit change doesn't add the index, it just makes use it. The index was added r93211 (July 2011) and altered to its current form in r94239 (August 2011).

Since both of those were put into SVN by Reedy, let's bring him in on this.


(In reply to comment #1)
> The index name has no log* prefix while other newer indexes on the table do.
> Do we definitely want it applied as-is?

It should be renamed to match the current naming conventions, IMO.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links