Last modified: 2014-02-12 23:47:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51218, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49218 - Previews with references show ugly error message
Previews with references show ugly error message
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on: 49239
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-05 23:00 UTC by Jon
Modified: 2014-02-12 23:47 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-06-05 23:00:32 UTC 
Due to bug 49217 when trying to preview content with a reference we get a nasty error rendered in the response.

We may have to workaround yet another API bug here as I suspect bug 49217 will be RESOLVED WONTFIX as is usually the case when I raise bugs for the API.

To replicate click edit
Replace textarea content with
<ref>[http://www.priberam.pt/DLPO/default.aspx?pal=saudade Dicionário Priberam da Língua Portuguesa]</ref>
and hit preview.
Comment 1 MZMcBride 2013-06-05 23:05:44 UTC 
Isn't this a classic case of garbage in, garbage out?

Can you describe what behavior you'd expect here? Your input is invalid. What would you like the response to be? Failing silently is surely worse than failing loudly, which is the current behavior.
Comment 2 Jon 2013-06-05 23:23:09 UTC 
It means you cannot do section level previews. I would expect the tag to be ignored in the output HTML but flagged as a warning in the API response. Why shouldn't I be able to render the reference with a 'broken' anchor tag?
Comment 3 MZMcBride 2013-06-05 23:28:53 UTC 
This is basically a duplicate of bug 5984.
Comment 4 Jon 2013-06-06 06:00:25 UTC 
As suspected bug closed WONTFIX. \o/ to another API hacky workaround coming to you soon.
Comment 5 Max Semenik 2013-06-06 09:57:31 UTC 
See bug 49239 for proper solution.
Comment 6 Jon 2013-06-11 20:24:45 UTC 
Turns out the API fix broke other things...
Comment 7 Gerrit Notification Bot 2013-06-11 20:27:33 UTC 
Related URL: https://gerrit.wikimedia.org/r/68046 (Gerrit Change Ieaa684b03ce57b2e9e64e4e18eb5ee48606cab5b)
Comment 8 Gerrit Notification Bot 2013-06-11 20:29:27 UTC 
https://gerrit.wikimedia.org/r/68046 (Gerrit Change Ieaa684b03ce57b2e9e64e4e18eb5ee48606cab5b) | change APPROVED and MERGED [by jenkins-bot]
Comment 9 Gerrit Notification Bot 2013-06-13 22:21:26 UTC 
Related URL: https://gerrit.wikimedia.org/r/68575 (Gerrit Change I261faade919608dab1f213f771dd9d7bc666deb6)
Comment 10 Gerrit Notification Bot 2013-06-14 13:58:13 UTC 
https://gerrit.wikimedia.org/r/68575 (Gerrit Change I261faade919608dab1f213f771dd9d7bc666deb6) | change APPROVED and MERGED [by jenkins-bot]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links