Wikimedia Bugzilla is closed!

(In reply to comment #0)
> $wgCapitalLinkOverrides is being ignored, but it appears $wgCapitalLinks is
> not
> in SWM_GlobalFunctions.php, SMW 1.8.
> 
> Thanks - john

Ignored where? Do you have a particular example?

## General notion

$wgCapitalLinkOverrides/$wgCapitalLinks are globals defined by MW which don't have be included by SMW as access is available via $GLOABLS['wgCapitalLinks'] or $GLOABLS['wgCapitalLinkOverrides']

SWM_GlobalFunctions.php (Defines.php in SMW 1.9) only specifies globals that are SMW related.

may be good to use MWNamespace::isCapitalized($intNamespace) as in...

function smwfNormalTitleDBKey( $text, $intNamespace ) {
	if( MWNamespace::isCapitalized($intNamespace) ) {
		$text = ucfirst( trim( $text ) );
	}
	else {
		$text = lcfirst( trim( $text ) );
	}
	return str_replace( ' ', '_', $text );
}
..snip..
function smwfNormalTitleText( $text ) {
	if( MWNamespace::isCapitalized($intNamespace) ) {
		$text = $wgContLang->ucfirst( trim( $text ) );
	}
	else {
		$text = $wgContLang->lcfirst( trim( $text ) );
	}
	return str_replace( '_', ' ', $text );
}

(note: above comment should have a new param on the smwfNormalTextTitle() method.)

Related to this is line 33 in SMW_DV_PropertyList.php:
		$namespace = smwfNormalTitleText( $propertyNameParts[0] );

1. Looks like it's normalizing namespace-names as if they were page-names, since one could specify a property named "dc:creator".

2. It may not be foresighted to assume there are only 2 strings resulting from the explode() on line 29... can one have Property:dc:creator, for instance?

(In reply to comment #3)
> (note: above comment should have a new param on the smwfNormalTextTitle()
> method.)

As a site note (I haven't looked at given examples yet) smwfNormalTextTitle should be deprecated and be replaced by a "normal" class object that can be injected which would allow separate unit testing.

If you feel up to it, you might want to tackle this and additionally provide some unit tests that ensures proper coverage otherwise it might take some time before someone is trying to dig into this.

Yes I agree smwfNormalTitleText & smwfNormalTitleDBKey should be deprecated as you say. I'll try at least some code and post here to be sure it's ok before I continue on? Thanks - john

Created attachment 12485 [details]
Chgs to 6 SMW files for bug 49219

Here's my changes to SMW for this problem. I have eliminated all six calls to SMWNormalTitleText which I found while none were found for SMWNormalTitleDBKey, in the SMW codebase. I have not checked other semantic extensions though. I have a variety of tests in ExpandTemplates (that won't do you much good) and results are as expected. Where might I look for existing SMW query parser tests?

Inventory
1. SMW_GlobalFunctions.php - removed two functions
2. SMW_SemanticData.php - added 3 public static flags
3. SMW_QueryProcessor.php - re-coded spots where removed calls
4. SMW_DV_Types, SMW_DV_Property & SMW_DV_PropertyList.php - re-code spots

I wanted to bounce these off you & ask for help unit testing.
Thanks - john

Thanks for your work but after I quick peek it leaves me with two general concerns.

The first remark is directed towards that changes should be submitted to Gerrit directly because I can't see from the posted files which part of the classes did change and potentially cause problems which leads to the second problem that your changes are based on SMW 1.8 which means that some of the changes can't be incorporate into SMW 1.9 because the base class has been updated in 1.9 already which makes it tedious to try to patch manually the files with the current master.

A general tactic is to incorporate changes with the current master and only after it passes unit tests on the master, a patch might be provided for a lower release (if absolutely necessary).

As for unit tests[1], the current 1.9 master has several (~50) unit tests available and I think I wrote even a test for the GlobalFunction.php which would fail now since those two methods are gone and the unit tests need to be updated.

SMW_SemanticData.php, SMW_QueryProcessor.php, SMW_DV_Types, SMW_DV_Property & SMW_DV_PropertyList.php are high risk classes and definitely need unit tests to ensure that no core functionality is broken but this can only be verified by having those changes in Gerrit and based on the current master in order for the continues integration platform (Jenkins) to run tests against the current master.

[1] https://www.semantic-mediawiki.org/wiki/PHPUnit_tests

oops I shouldhave said SMW_QueryParser.php not SMW_QueryProcessor.php above.

so the next step is to check these files into gerrit, as some branch of smw? I'd think I'd need privledges to do that - I have created one project already, with some difficulty, to be kind about it!