Last modified: 2013-08-01 09:57:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51264, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49264 - Apply strict validation when constructing DataValue objects
Apply strict validation when constructing DataValue objects
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks: 48888 48965 49186 49425
  Show dependency tree / graph
 
Reported: 2013-06-06 16:56 UTC by Daniel Kinzler
Modified: 2013-08-01 09:57 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2013-06-06 16:56:54 UTC 
DataValue objects should perform strict validation on the parameters they receive in their constructor, and throw well defined and informative exceptions when validation fails.

The API needs to catch these exceptions and turn them into an appropriate API error response.
Comment 1 Gerrit Notification Bot 2013-06-11 10:20:03 UTC 
Related URL: https://gerrit.wikimedia.org/r/67962 (Gerrit Change I6990983ef0c0cad7c9d4f271bdf803902b94230b)
Comment 2 Gerrit Notification Bot 2013-06-12 10:58:54 UTC 
Related URL: https://gerrit.wikimedia.org/r/68150 (Gerrit Change I8916062971114d6bc3188dd4f0322c28cc54403e)
Comment 3 Gerrit Notification Bot 2013-06-12 10:59:53 UTC 
https://gerrit.wikimedia.org/r/68150 (Gerrit Change I8916062971114d6bc3188dd4f0322c28cc54403e) | change APPROVED and MERGED [by jenkins-bot]
Comment 4 Gerrit Notification Bot 2013-06-12 11:03:37 UTC 
https://gerrit.wikimedia.org/r/67962 (Gerrit Change I6990983ef0c0cad7c9d4f271bdf803902b94230b) | change ABANDONED [by Daniel Kinzler]
Comment 5 Gerrit Notification Bot 2013-06-12 11:05:37 UTC 
Related URL: https://gerrit.wikimedia.org/r/68152 (Gerrit Change I72d6b6d890718c07006c306c254479ce0789067e)
Comment 6 Gerrit Notification Bot 2013-06-16 15:27:53 UTC 
Related URL: https://gerrit.wikimedia.org/r/68952 (Gerrit Change I8286b6c1ce31be0d9cb1ccd34ea3a763d4fb223b)
Comment 7 Gerrit Notification Bot 2013-06-20 14:29:21 UTC 
Related URL: https://gerrit.wikimedia.org/r/69659 (Gerrit Change I1e2543c75f0407a22e531aac67ace9cf3f5670ae)
Comment 8 Gerrit Notification Bot 2013-06-25 15:42:20 UTC 
Related URL: https://gerrit.wikimedia.org/r/70433 (Gerrit Change I9920286723e04ba2005b608583c45338f53d21fd)
Comment 9 Gerrit Notification Bot 2013-06-25 17:18:58 UTC 
Related URL: https://gerrit.wikimedia.org/r/70443 (Gerrit Change Id27f19020e2fd75a250fea4deb1eb94aeeff6f3f)
Comment 10 Gerrit Notification Bot 2013-07-02 13:01:48 UTC 
Change 68952 abandoned by Daniel Kinzler:
(bug 49264) Handle corrupt data values gracefully.

Reason:
Use I9920286723 instead. It seems that handling bad values on the DataValue level is less awkward.

https://gerrit.wikimedia.org/r/68952
Comment 11 Gerrit Notification Bot 2013-07-25 16:29:16 UTC 
Change 70433 merged by Jeroen De Dauw:
(bug 49264) Handle bad values using UnDeserializableValue.

https://gerrit.wikimedia.org/r/70433
Comment 12 Gerrit Notification Bot 2013-07-25 18:19:47 UTC 
Change 68152 merged by jenkins-bot:
(bug 49264, bug 48965) validate time format.

https://gerrit.wikimedia.org/r/68152
Comment 13 Gerrit Notification Bot 2013-07-26 11:30:43 UTC 
Change 70443 merged by jenkins-bot:
(bug 49264) Handle UnDeserializableValue gracefully.

https://gerrit.wikimedia.org/r/70443
Comment 14 Gerrit Notification Bot 2013-07-26 11:34:20 UTC 
Change 68002 merged by jenkins-bot:
(bug 49264) Handle UnDeserializableValue gracefully.

https://gerrit.wikimedia.org/r/68002
Comment 15 Gerrit Notification Bot 2013-07-26 15:27:57 UTC 
Change 69659 merged by jenkins-bot:
(bug 49264) Make SnakValidator fail on bad values.

https://gerrit.wikimedia.org/r/69659
Comment 16 abraham.taherivand 2013-08-01 09:57:42 UTC 
Verified in Wikidata demo July 31th.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links