Last modified: 2014-08-22 04:27:57 UTC
Currently the https://en.m.wikipedia.org/wiki/Special:Notifications page consists of a single ul element and uses '.mw-echo-date-section' as a divider. Really the markup should be a series of h2 elements and separate lists. This would also remove the need for mw-echo-notification as styling could work like so: #mw-echo-special-container h2 #mw-echo-special-container li e.g. <div id="mw-echo-special-container"> <h2>May 09</h2> <ul> <li data-notification-category="edit-user-talk"> </li> </ul> <ul> <li data-notification-category="edit-user-talk"> </li> </ul> </div> Currently the mobile site is having to introduce unnecessary styling rules which would be avoided with h2s
Change 71523 had a related patch set uploaded by Jdlrobson: Bug 49269: Echo markup adjustments https://gerrit.wikimedia.org/r/71523
Change 71523 merged by jenkins-bot: Bug 49269: Echo markup adjustments https://gerrit.wikimedia.org/r/71523
Change 71729 had a related patch set uploaded by Bsitu: Revert "Bug 49269: Echo markup adjustments" https://gerrit.wikimedia.org/r/71729
Change 71729 merged by Bsitu: Revert "Bug 49269: Echo markup adjustments" https://gerrit.wikimedia.org/r/71729
Looks like I merged 71523 prematurely. The ids for the uls need to be changed to classes and it needs to make sure that it handles adding new notifications in correctly when clicking the Load More button.
Change 73529 had a related patch set uploaded by Kaldari: Render dates as headings https://gerrit.wikimedia.org/r/73529
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/257
Change 154220 had a related patch set uploaded by Jdlrobson: WIP: make Special:Notifications semantically correct https://gerrit.wikimedia.org/r/154220
Change 73529 abandoned by Bsitu: Render dates as headings Reason: This will be handled in the newer patch: https://gerrit.wikimedia.org/r/#/c/154220/ https://gerrit.wikimedia.org/r/73529
