Last modified: 2013-07-09 23:07:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51289, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49289 - Visible br is shown in template
Visible br is shown in template
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-07 04:46 UTC by Matthew Flaschen
Modified: 2013-07-09 23:07 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-06-07 04:46:46 UTC
On https://en.wikipedia.org/w/index.php?title=Earth&oldid=558616159&veaction=edit , there is a visible '</br>' in the infobox.
Comment 1 James Forrester 2013-06-07 21:55:33 UTC
This is as it comes through from Parsoid - http://parsoid.wmflabs.org/en/Earth?oldid=558616159 - so re-filing there.
Comment 2 Kelson [Emmanuel Engelhart] 2013-06-08 10:04:55 UTC
This bug seems to impact all infoboxes. See here an other example:
http://parsoid.wmflabs.org/en/Norman_Selfe

IMO, this could be related to the LUA code behind this template. See my comment there:
https://en.wikipedia.org/wiki/Template_talk:Infobox#Non-valid_HTML_code_.3Cbr.3E
Comment 3 Kelson [Emmanuel Engelhart] 2013-06-08 11:00:29 UTC
Problem in "Module:Infobox" and "Module:HtmlBuilder" were fixed, see the comments at:
https://en.wikipedia.org/wiki/Template_talk:Infobox#Non-valid_HTML_code_.3Cbr.3E

But, we maybe still need to increase parsoid tolerance regarding this particular use case...
Comment 4 ssastry 2013-06-08 13:18:31 UTC
Thanks Kelson for getting the templates fixed.  If we need to increase tolerance for this buggy use of </br>, we will have to use some hacks and suppress it, which we will if this proves to be common.  But for now, fixing templates (as you got done) is still the best solution.

Bug 46705 has an idea (if/when we get around to it) to deal with bad wikitext and flag them for fixing.
Comment 5 Andre Klapper 2013-07-04 10:34:57 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Comment 6 Gabriel Wicke 2013-07-09 23:07:00 UTC
Fixed by https://gerrit.wikimedia.org/r/#/c/72684/.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links