Last modified: 2013-10-24 09:54:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51313, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49313 - qa/browsertests has no license information
qa/browsertests has no license information
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Jeff Hall
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-07 17:15 UTC by Željko Filipin
Modified: 2013-10-24 09:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Željko Filipin 2013-06-07 17:15:13 UTC
I guess we need a LICENSE file in repository root and a header in every file stating the license. I have no license preference, we should probably use the same one as mediawiki.
Comment 1 Željko Filipin 2013-07-12 12:01:47 UTC
Asked Luis Villa what should we do. Waiting for reply.
Comment 2 Luis Villa (WMF Legal) 2013-07-12 18:09:23 UTC
I think it makes sense to:

1. Copy https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/COPYING into https://git.wikimedia.org/tree/qa%2Fbrowsertests (Please rename it LICENSE instead of COPYING - that's not traditional, but it is more clear.)

2. Create a CREDITS file; suggest that anyone who has made a significant contribution put their name/handle there.

3. Use a brief header, instead of the traditional full GPL header; something like:

----
This file is subject to the license terms in the LICENSE file found in the browsertests top-level directory of and at https://git.wikimedia.org/tree/qa%2Fbrowsertests/HEAD/LICENSE. No part of browsertests, including this file, may be copied, modified, propagated, or distributed except according to the terms contained in the LICENSE file.

Copyright 2013 by the Mediawiki developers. See the CREDITS file in the browsertests top-level directory and at https://git.wikimedia.org/tree/qa%2Fbrowsertests/HEAD/CREDITS.
----

This approach will keep the headers smaller (particularly nice for something like this) and means there is less to update should we ever need to clarify something.

FYI, these recommendations are mostly based on https://www.softwarefreedom.org/resources/2012/ManagingCopyrightInformation.html (We should probably consider working in that direction across all new projects, but that's a long-term project - no hurry.)

I'd love to make the patch myself, but I'm swamped for the next few weeks...
Comment 3 Željko Filipin 2013-07-13 10:33:08 UTC
Luis, thanks for the quick reply! Feel free to make the change yourself when you have the time, but there is no rush. A few volunteers and employees are committing to the repository, somebody will make the change these days, now that we know what should be done.
Comment 4 Jeff Hall 2013-09-06 22:25:20 UTC
Seems like a pretty straightforward task, so I can take this one on (but let me know if it should really be handled by a Wikimedia employee, which I am not!)
Comment 5 Željko Filipin 2013-09-07 14:24:40 UTC
Jeff, feel free to add license information. Thanks! :)
Comment 6 Jeff Hall 2013-09-16 18:32:25 UTC
List of contributors to the GitHub repo:

https://github.com/wikimedia/qa-browsertests/graphs/contributors
Comment 7 Jeff Hall 2013-09-28 03:43:06 UTC
Submitted a pull request with these changes:

https://github.com/wikimedia/qa-browsertests/pull/10

For the record, I made most of the changes using Erik Osterman's "copyright-header" gem:

https://github.com/osterman/copyright-header
Comment 8 Gerrit Notification Bot 2013-09-28 03:45:46 UTC
Change 86355 had a related patch set uploaded by Yuvipanda:
Adding new CREDITS and LICENSE files, and license headers to all files, per bug 49313.

https://gerrit.wikimedia.org/r/86355
Comment 9 Željko Filipin 2013-10-04 10:41:55 UTC
Jeff, thanks for the commit!

Luis, can you please take a quick look and let us know if this can be merged into master?
Comment 10 Gerrit Notification Bot 2013-10-24 09:51:20 UTC
Change 86355 merged by Zfilipin:
Adding new CREDITS and LICENSE files, and license headers to all files.

https://gerrit.wikimedia.org/r/86355
Comment 11 Željko Filipin 2013-10-24 09:54:26 UTC
Luis, if anything should be fixed, please let us know.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links