Last modified: 2013-06-12 21:16:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51314, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49314 - Cite should insert space between backlinks and content
Cite should insert space between backlinks and content
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
token-stream transforms (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-07 17:21 UTC by Gabriel Wicke
Modified: 2013-06-12 21:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-06-07 17:21:54 UTC
We are not reliably inserting a space between the backlinks and the reference content in the references section:

echo '<ref name=foo>a</ref><ref name=foo/><references/>' | node parse --extensions ref,references
<body><span about="#mwt4" class="reference" data-mw='{"name":"ref","body":{"html":"a"},"attrs":{"name":"foo"}}' id="cite_ref-foo-1-0" rel="dc:references" typeof="mw:Extension/ref" data-parsoid='{"src":"<ref name=foo>a</ref>","dsr":[0,21,14,6]}'><a href="#cite_note-foo-1">[1]</a></span><span about="#mwt5" class="reference" data-mw='{"name":"ref","attrs":{"name":"foo"}}' id="cite_ref-foo-1-1" rel="dc:references" typeof="mw:Extension/ref" data-parsoid='{"src":"<ref name=foo/>","dsr":[21,36,15,0]}'><a href="#cite_note-foo-1">[1]</a></span><ol about="#mwt6" class="references" data-mw='{"name":"references","attrs":{}}' typeof="mw:Extension/references" data-parsoid='{"tsr":[36,49],"selfClose":true,"src":"<references/>","dsr":[36,49,13,0]}'><li about="#cite_note-foo-1" id="cite_note-foo-1"><span rel="mw:referencedBy">↑ <a href="#cite_ref-foo-1-0">1.0</a> <a href="#cite_ref-foo-1-1">1.1</a></span><span>a</span></li></ol>
</body>

Note the missing space in <a href="#cite_ref-foo-1-1">1.1</a></span><span>a</span>

Should probably be: <a href="#cite_ref-foo-1-1">1.1</a></span> <span>a</span>
Comment 1 Gerrit Notification Bot 2013-06-12 21:08:41 UTC
Related URL: https://gerrit.wikimedia.org/r/68286 (Gerrit Change Ie67ba1c332451b60107f6fb946efeafc15485b50)
Comment 2 Gerrit Notification Bot 2013-06-12 21:12:36 UTC
https://gerrit.wikimedia.org/r/68286 (Gerrit Change Ie67ba1c332451b60107f6fb946efeafc15485b50) | change APPROVED and MERGED [by jenkins-bot]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links