Last modified: 2013-06-09 22:55:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51369, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49369 - Track review branches in GitBlit
Track review branches in GitBlit
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-09 22:01 UTC by Ori Livneh
Modified: 2013-06-09 22:55 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2013-06-09 22:01:07 UTC
As far as I can determine, Gitblit currently only tracks merged changes. Gerrit's ability to query for a commit hash independent of its status has gotten people accustomed to using commit hashes to refer to changes. This becomes problematic if Gitblit is used (in templates, etc.) to construct permanent URLs to changes, as Gitblit does not currently track unmerged changes, meaning the change referenced in the URL is not resolved and the user is silently redirected to the main page.
Comment 1 Chad H. 2013-06-09 22:45:04 UTC
Um, it should track everything, since Gerrit links to it on unmerged changes. The summary page and log may not show a running list of unmerged things but I'd be willing to guess those pages only watch refs/heads/ and refs/tags/ (I'll note the behavior in Gitweb was identical here)
Comment 2 Ori Livneh 2013-06-09 22:55:06 UTC
(In reply to comment #1)
> Um, it should track everything, since Gerrit links to it on unmerged changes.

Yes, you're right. I mis-diagnosed the problem. It ended up being something unrelated (the URL to the commit included non-URL-encoded slashes, which threw off GitBlit).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links