Last modified: 2013-06-14 16:35:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51394, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49394 - VisualEditor: Misc. issues
VisualEditor: Misc. issues
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-06-13
Assigned To: James Forrester
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-10 18:05 UTC by MZMcBride
Modified: 2013-06-14 16:35 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-06-10 18:05:27 UTC
https://en.wikipedia.org/w/index.php?title=Mavericks_(location)&diff=559262706&oldid=559261658

There are a few issues here:

* the diff presented to the user prior to save didn't include any of these extraneous changes (or I obviously wouldn't have saved the edit);

* there's <nowiki> markup being inserted throughout the page, breaking a number of links; and

* there's spacing normalization being done to template parameters, resulting in an even dirtier diff.

I'm not sure how these issues should be split out or if there are existing bug reports for all three of these issues.
Comment 1 MZMcBride 2013-06-10 18:22:38 UTC
This bug is probably a wash in terms of being an actionable report, so I'll just use it to log other diffs I'm coming across via <https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=visualeditor>.


<nowiki> corruption:

https://en.wikipedia.org/w/index.php?title=Black_Country_Communion&curid=25818560&diff=559205644&oldid=547680063


<nowiki/> weirdness:

https://en.wikipedia.org/w/index.php?title=Lightning_(software)&diff=prev&oldid=559252596


Possible unintentional HTML comment removal; <nowiki> corruption:

https://en.wikipedia.org/w/index.php?title=Underworld_(band)&diff=prev&oldid=559255806
Comment 5 Roan Kattouw 2013-06-10 20:12:47 UTC
(In reply to comment #3)
> Misspelling trap:
> 
> https://en.wikipedia.org/w/index.
> php?title=Pepsi_Next&curid=35519554&diff=559230837&oldid=559223494
That one isn't a serialization or round-tripping bug. The user edited the text of the link, but didn't edit the target.

Arguably, links where the text equals the target should have the target track the text when the user edits them. Or maybe they shouldn't. James?

(In reply to comment #2)
> <Gallery> funkiness:
> 
> https://en.wikipedia.org/w/index.
> php?title=British_Rail_Class_50&curid=1448622&diff=559199747&oldid=558786539
Probably a Parsoid bug due to Gallery being capitalized. CCing Gabriel.

The nowiki issues also look like Parsoid serialization bugs to me.
Comment 6 MZMcBride 2013-06-10 20:21:16 UTC
Expansion wtf (warning: large diff):

https://en.wikipedia.org/w/index.php?title=Breast_cancer&diff=558696523&oldid=558695500
Comment 7 ssastry 2013-06-11 21:01:33 UTC
The <nowiki> tags in Cite transclusions in ref tags is a Parsoid bug.  I have that on my radar -- will look into that next possibly.

As for <nowiki> tags in other places, looking at bug reports on parsoid.wmflabs.org, there are three different reasons

* due to the bug in ref-tags I mentioned above

* user entering wikitext in the visual editor (Ex: ==See also==* [[Tomato (company)]] in https://en.wikipedia.org/w/index.php?title=Underworld_(band)&diff=prev&oldid=559255806 based on looking at the HTML sent to Parsoid).  I've seen wikitext entered via VE in a few bug reports -- all such wikitext will be nowiki escaped by Parsoid

* Empty heading left behind in the visual editor (tracked in Bug 49452)
Comment 8 Andre Klapper 2013-06-11 23:17:37 UTC
MZMcBride: For future reference, only one single bug per report please. Also see https://www.mediawiki.org/wiki/How_to_report_a_bug . I'd normally close such tickets as INVALID and ask the reporter to file separate tickets.
Comment 9 ssastry 2013-06-14 16:32:23 UTC
The <nowiki> tags in Cite transclusions (and other tpl transclusions, if they showed up) should be fixed.  My suggestion is to close this bug now since the VE heading bug is tracked separately, and as for user entering wikitext, well, that could be a feature request for VE alerting the user when (s)he enters wikitext, or maybe a FAQ entry or something. 

In all cases, this bug wont be much useful beyond this point.
Comment 10 James Forrester 2013-06-14 16:35:28 UTC
Marking as such.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links