Last modified: 2013-06-13 18:19:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51402, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49402 - "contributors" history link in app is broken
"contributors" history link in app is broken
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
3.2 (iOS) / 1.2 (Android)
All All
: High major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-10 19:40 UTC by Luis Villa (WMF Legal)
Modified: 2013-06-13 18:19 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot. (52.70 KB, image/png)
2013-06-10 20:59 UTC, Luis Villa (WMF Legal)
Details

Description Luis Villa (WMF Legal) 2013-06-10 19:40:23 UTC
To reproduce:
1) Open the wikipedia app (beta).
2) Scroll down.
3) See "contributors" link to history.
4) tap
5) Get blank page. 

This is a license compliance problem, and should be fixed.

[I think that this is different from bug 42660, but not 100% sure.]
Comment 1 Yuvi Panda 2013-06-10 20:52:09 UTC
Can you tell me if this is Android or iOS? And if so, which version of Android / iOS?
Comment 2 Yuvi Panda 2013-06-10 20:54:30 UTC
(Just checked, works for me on Android)
Comment 3 Luis Villa (WMF Legal) 2013-06-10 20:54:56 UTC
Ah, my apologies - didn't correctly set the field. Android Jelly Bean; latest beta release of the app (1.4beta1).
Comment 4 Yuvi Panda 2013-06-10 20:55:58 UTC
Hmm, weird (I used the exact combination). Does it show up blank in the browser, or in the app itself?
Comment 5 Luis Villa (WMF Legal) 2013-06-10 20:59:11 UTC
Created attachment 12509 [details]
Screenshot.

It comes up in the app; here is a screenshot of what I see.
Comment 6 Yuvi Panda 2013-06-10 21:07:46 UTC
Okay, I see what is happening. History is supposed to open in an external browser always - except that we seem to 'loop back' in to the app if you have indiscriminately selected the app to open all wikipedia links.

If you go to Settings -> Apps -> Wikipedia -> Clear Defaults, and tap contributions again, it should give you the choice of opening it in the app itself or a browser - selecting the browser should 'fix' this issue.

IIRC we put in some hack that tried to make sure that the app never opened history links, and they were always handled by the browser - that might have broken in the new release. 

Does this still count as a licence breakage, since it happens only under certain circumstances? I'd poke at it if so, if not I'm inclined to let the app rest in peace - we consider the current wikipedia app (and its Phonegap platform) 'in maintenance mode'
Comment 7 Luis Villa (WMF Legal) 2013-06-11 01:07:49 UTC
"if you have indiscriminately selected the app to open all wikipedia links."

If you're using the OS as designed, it encourages you to select the app for all wikipedia.org links -  you get a dialog all the time if you don't, and you've got no reason to select a browser from that dialog once you've got the app installed. So that's why I did it :) So... it's sort of a default bug (though not strictly speaking a default).
Comment 8 Yuvi Panda 2013-06-13 18:17:03 UTC
Fix in https://github.com/wikimedia/WikipediaMobile/pull/327.

Need to figure out how / when to make a release though.
Comment 9 Yuvi Panda 2013-06-13 18:19:10 UTC
Brion merged it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links