Last modified: 2013-06-10 21:13:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51410, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49410 - Semantic Forms using holds template/embed in field inside of another form breaks template output
Semantic Forms using holds template/embed in field inside of another form bre...
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-10 20:40 UTC by Jamie Thingelstad
Modified: 2013-06-10 21:13 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jamie Thingelstad 2013-06-10 20:40:07 UTC
I'm using a multiple form inside of another form and the UI works well, but the template it produces is broken. The form is like this (sorry for no link, the wiki this is on isn't publicly available):

{{{for template|Foo}}}
A: {{{field|A}}}<br/>
B: {{{field|B}}}<br/>
SpecialStuff: {{{field|Special stuff|holds template}}}<br/>
{{{for template|Specials|multiple|embed in field=Foo[SpecialStuff]}}}
X: {{{field|X}}}<br/>
Y: {{{field|Y}}}<br/>
{{{end template}}}
C: {{{field|C}}}<br/>
D: {{{field|D}}}<br/>
{{{end template}}}

This works fine and is awesome in the form UI. However, the template that it writes is problematic because the "inner template" closes out the outer one. You get something like.

{{{Foo
|A=A
|B=B
|SpecialStuff={{Specials
|X=1
|Y=2}}{{Specials
|X=5
|Y=6}}
}}

|C=C
|D=D
}}

Obviously the last half is orphaned.
Comment 1 Jamie Thingelstad 2013-06-10 20:46:43 UTC
I created a version of this issue on a public URL so you can see what I mean:

http://scratch.wikiwonders.net/wiki/Special:FormEdit/Embed_test/ddd
Comment 2 Yaron Koren 2013-06-10 20:54:10 UTC
Hi - you should never have one "for template" call inside another; that's unsupported behavior.
Comment 3 Jamie Thingelstad 2013-06-10 20:59:56 UTC
:-( It works really well in the Form interface.
Comment 4 Yaron Koren 2013-06-10 21:13:53 UTC
Oh well. :) Marking this as "wontfix".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links