Last modified: 2013-11-14 14:28:23 UTC
when running phpunit.php without specifying a target file or class (so, running all tests or using --group and/or --filter), it does not find/run TextContentTest and JavaScriptContentTest. The related test classes CssContentTest and WikitextContentTest work fine. There seems to be something odd going on here involving inheritance: CssContentTest extends JavaScriptContentTest extends TextContentTest extends MediaWikiLangTestCase. Note that the top class, CssContentTest, works. If I remove it, JavaScriptContentTest suddenly works! As if phpunit was skipping any tests class that serve as a base class for another test... But when I tried to verified this with a minimal test case, I couldn't: both trivial test classes, the parent and the child, where found and executed. Strange. This is with PHPUnit 3.7.19 and PHP 5.4.9-4ubuntu2on Ubuntu. I access my MediaWiki installation via a symlinked path, but don't use symlinks inside the install.
Point in case: https://gerrit.wikimedia.org/r/#/c/28199/11 should not have passed the gateway verification, since it causes a fatal error in TextContentTest.
Setting to "major", since it can and has caused broken code to be merged into master. If we rely on phpunit for gateway testing, it should not just skip some tests.
