Last modified: 2013-06-29 05:27:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51484, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49484 - Remove mw:ExtLink/URL type and automatically switch between serialization variants
Remove mw:ExtLink/URL type and automatically switch between serialization var...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 46027
  Show dependency treegraph
 
Reported: 2013-06-12 16:38 UTC by Gabriel Wicke
Modified: 2013-06-29 05:27 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-06-12 16:38:31 UTC
We currently mark up auto-linked external links (source http://example.com/) as mw:ExtLink/URL (see http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#External_links for the spec). There is however no need to distinguish between plain external and auto-linked external URLs on the client side if we automatically convert between the two forms as needed. So we should replace all uses of mw:ExtLink/URL with a plain mw:ExtLink and add some extra info to data-parsoid and cleverness to our serializer.

Basically:

* If the target and the link text agree, we can serialize a modified or new link as an URL link in wikitext.
* If a former URL link's content text is modified by the editor and does not match the target any more, convert to a regular external link.
* If an unmodified external link *could* be rendered as an URL link, but is marked up as a full external link in the original Wikitext, then preserve this non-minimal serialization on round-trip.

Change detection requires custom shadowing similar to the logic we use for WikiLinks.
Comment 1 Gerrit Notification Bot 2013-06-20 21:32:35 UTC
Related URL: https://gerrit.wikimedia.org/r/69795 (Gerrit Change Ifa13f93906f09c6d7d019e6b652d11fa48ca2420)
Comment 2 Gabriel Wicke 2013-06-21 02:14:35 UTC
Note: The above commit was not actually related.
Comment 3 Gerrit Notification Bot 2013-06-29 04:59:51 UTC
Change 71162 had a related patch set uploaded by GWicke:
Bug 46027: Drop mw:ExtLink/URL

https://gerrit.wikimedia.org/r/71162
Comment 4 Gerrit Notification Bot 2013-06-29 05:06:11 UTC
Change 71162 had a related patch set uploaded by GWicke:
Bug 46027, bug 49484: Drop mw:ExtLink/URL

https://gerrit.wikimedia.org/r/71162
Comment 5 Gerrit Notification Bot 2013-06-29 05:12:27 UTC
Change 71162 merged by jenkins-bot:
Bug 46027, bug 49484: Drop mw:ExtLink/URL

https://gerrit.wikimedia.org/r/71162

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links