Last modified: 2013-06-12 20:16:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51490, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49490 - Cite crash on es:Estadio_Deportivo_Cali
Cite crash on es:Estadio_Deportivo_Cali
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
token-stream transforms (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-12 17:59 UTC by Gabriel Wicke
Modified: 2013-06-12 20:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-06-12 17:59:28 UTC 
ERROR: TypeError: Cannot read property 'length' of undefined
Stack trace: TypeError: Cannot read property 'length' of undefined
    at RefGroup.add (/home/gabriel/src/mw/extensions/Parsoid/js/lib/ext.Cite.js:171:65)
    at References.extractRefFromNode (/home/gabriel/src/mw/extensions/Parsoid/js/lib/ext.Cite.js:326:18)
    at generateReferences (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2549:13)
    at generateReferences (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2553:5)
    at generateReferences (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2553:5)
    at generateReferences (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2553:5)
    at DOMPostProcessor.doPostProcess (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2819:22)
    at [object Object].emit (events.js:67:17)
    at [object Object].onEnd (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.HTML5TreeBuilder.node.js:76:7)
    at SyncTokenTransformManager.emit (events.js:64:17)
Comment 1 Gerrit Notification Bot 2013-06-12 19:29:01 UTC 
Related URL: https://gerrit.wikimedia.org/r/68219 (Gerrit Change Ib5cf7cce6fa4acd88e3d49ca9d4390a61bfddd7e)
Comment 2 Gerrit Notification Bot 2013-06-12 20:15:50 UTC 
https://gerrit.wikimedia.org/r/68219 (Gerrit Change Ib5cf7cce6fa4acd88e3d49ca9d4390a61bfddd7e) | change APPROVED and MERGED [by jenkins-bot]
Comment 3 Gabriel Wicke 2013-06-12 20:16:09 UTC 
This was caused by a ref group named 'constructor'.

Should probably audit the code to see if we store other user-supplied strings in objects without prefixing them.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links