Last modified: 2014-03-21 22:44:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51502, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49502 - VisualEditor: Link input widget filters out redirects for target pages, but this logic is wrong for existing pages
VisualEditor: Link input widget filters out redirects for target pages, but t...
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Alex Monk
:
: 49540 50274 59208 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-12 22:11 UTC by James Forrester
Modified: 2014-03-21 22:44 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-06-12 22:11:51 UTC
Have a link [[Foo]] which is a redirect to [[Foobar]].

Inspect link; it will suggest:

New pages
  Foo
Existing pages
  Foobar

This is because "Foo" does not come back in the list of pages you can link to - which is filtered to remove redirects - but we should special-case the existing link.
Comment 1 James Forrester 2013-06-13 19:56:25 UTC
*** Bug 49540 has been marked as a duplicate of this bug. ***
Comment 2 Ed Sanders 2013-06-21 15:56:58 UTC
In my local copy, the redirect URL is not filtered out, but I did notice another bug in that code: https://gerrit.wikimedia.org/r/69871
Comment 3 James Forrester 2013-07-11 05:13:08 UTC
*** Bug 50274 has been marked as a duplicate of this bug. ***
Comment 4 Sage Ross 2013-08-23 17:19:36 UTC
I'd say the desired behavior would be that the link inspector show the existing redirect in different way (such as blue but with a parenthetical note that this is a redirect).

In most cases, the link to the target article is the preferred link choice, but in many cases the redirect is also valid. For cases where the redirect points to a subsection, the redirect is probably the preferred link most of the time.
Comment 5 James Forrester 2014-01-18 05:48:54 UTC
*** Bug 59208 has been marked as a duplicate of this bug. ***
Comment 6 Quim Gil 2014-01-18 08:08:14 UTC
Many redirects exist because they respond to expected (simplified) alternative names, plurals, synonyms, non-complete names of people and places, and popular uses in general. It is likely that these popular uses are also used in articles. When selecting a word, the difference between VE recognizing or not these redirects is important:

* If the redirect is recognized and the destination page is shown, most editors will understand the difference and will choose the complete name.

* If the redirect is not shown then you can be a lazy editor and insert the link (having no idea whether it will result in a red or blue link), you can avoid the link altogether just in case, or you can be a good editor (as I try to be), open a new tab, and search that term only to find that many times such term is a known redirect.

Do the latter 20 times in a long article and you will come to this bug report as I did. I found this to be a big nuisance in real editing. (with the side benefit that I tested Cirrus Search more and I even found a bug, thanks to these deviations caused by VE)

PS: or simply show the redirects in italics, as they are already displayed in some MediaWiki lists.
Comment 7 Alex Monk 2014-02-02 03:36:46 UTC
I can't reproduce this bug.
Comment 8 Alex Monk 2014-02-02 03:37:44 UTC
James couldn't either so RESOLVED WORKSFORME
Comment 9 Elitre 2014-03-11 12:44:45 UTC
There are a bunch of bugs about this, so I'm pretty sure I'm adding my comment to the wrong one :D
Anyway, it is possible that the inspector does not recognize immediately a page as an existing redirect. See https://en.wikipedia.org/wiki/File:VE_wrong_link_state_in_link_editor.png .
https://en.wikipedia.org/wiki/New_York_Kennedy is a valid redirect page.
Unfortunately this is not easy to reproduce. 
(I never managed to do it by just typing New York Kennedy and then wikiling those words, anyway.)
I sometimes managed to reproduce by selecting a completely random word (or even more than one), clicking on the chain icon, writing New York Kennedy in the dialog. Every time though it does correct itself if, after observing the same result from the screenshot above, you click again in the text field, so the page will correctly appear as a blue link listed as a redirect.
Comment 10 Elitre 2014-03-11 13:10:48 UTC
Another couple of examples I found:
I write Indian religion, select the two words and try to add the relevant link; it doesn't recognize the page as an existing redirect, while it lists Indian religions as "matching page".
Same story for Tafkap; in this case, a couple of all caps variants are listed as redirects.
In these cases the "click in the text field" trick didn't work.
Comment 11 James Forrester 2014-03-21 22:44:04 UTC
AFAICT this underlying bug was fixed in October; the issue that MediaWiki's search system sometimes comes back with bad results from time to time (falsely claiming that short titles don't exist) is distinct, as part of bug 54361.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links