Last modified: 2013-06-27 16:25:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51505, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49505 - Allows playing native FLAC files (not in Ogg container)
Allows playing native FLAC files (not in Ogg container)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-12 23:09 UTC by Matthew Flaschen
Modified: 2013-06-27 16:25 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-06-12 23:09:54 UTC
As bug 32103 says, Ogg FLAC is handled by TimedMediaHandler, but regular straight FLAC is not.  The latter should also be playable (probably via transcoding), which would then make it reasonable to allow uploading them to Commons.
Comment 1 Gerrit Notification Bot 2013-06-14 12:43:38 UTC
Related URL: https://gerrit.wikimedia.org/r/68642 (Gerrit Change I7e4d3471832510b2c90a1279514266efd60481cf)
Comment 2 Kelson [Emmanuel Engelhart] 2013-06-14 13:05:51 UTC
So great! Please, let us know as soon as we can test it somewhere online.
Comment 3 Andre Klapper 2013-06-27 12:04:52 UTC
Patch got merged, anything else left to do here or can this be closed as RESOLVED FIXED?
Comment 4 Bawolff (Brian Wolff) 2013-06-27 16:15:00 UTC
(In reply to comment #3)
> Patch got merged, anything else left to do here or can this be closed as
> RESOLVED FIXED?

Yes, it's fixed.

(In reply to comment #2)
> So great! Please, let us know as soon as we can test it somewhere online.

It will be live on commons probably Monday July 8. It should be live on test.wikipedia.org, test2.wikipedia.org and mediawiki.org sometime today I believe.
Comment 5 Tomasz W. Kozlowski 2013-06-27 16:21:00 UTC
(In reply to comment #4)

> It will be live on commons probably Monday July 8. It should be live on
> test.wikipedia.org, test2.wikipedia.org and mediawiki.org sometime today I
> believe.

Commons has to allow accepting this format first, which requires a commit to InitialiseSettings.php ($wmgFileExtensions), since the default settings for $wgFileExtensions do not include .flac (yet).

So even if TimedMediaHandler will accept .flac files, it still won't be possible to upload them in the first place.
Comment 6 Bawolff (Brian Wolff) 2013-06-27 16:23:47 UTC
(In reply to comment #5)
> (In reply to comment #4)
> 
> > It will be live on commons probably Monday July 8. It should be live on
> > test.wikipedia.org, test2.wikipedia.org and mediawiki.org sometime today I
> > believe.
> 
> Commons has to allow accepting this format first, which requires a commit to
> InitialiseSettings.php ($wmgFileExtensions), since the default settings for
> $wgFileExtensions do not include .flac (yet).
> 
> So even if TimedMediaHandler will accept .flac files, it still won't be
> possible to upload them in the first place.

TMH modifies $wgFileExtensions after InitialiseSettings, so once tmh gets updated, .flac will be allowed, no config change needed. Note how .webm is not in $wgFileExtensions.
Comment 7 Tomasz W. Kozlowski 2013-06-27 16:25:18 UTC
Oh noes. I actually did read the documentation for $wgFileExtensions before posting that, and there wasn't anything about TMH there :-(

Perhaps the documentation on MW.org needs updating (hah! that's something new!).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links