Last modified: 2014-07-10 05:42:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51519, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49519 - UserMerge should be re-factored using FormSpecialPage
UserMerge should be re-factored using FormSpecialPage
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UserMerge (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-13 08:20 UTC by Tyler Romeo
Modified: 2014-07-10 05:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tyler Romeo 2013-06-13 08:20:48 UTC 
Purely a code enhancement, but it would be better to re-factor the UserMerge page into a FormSpecialPage. It helps to get rid of repeated code and can also make validation automatic.
Comment 1 T. Gries 2013-06-13 08:31:38 UTC 
(In reply to comment #0)
> Purely a code enhancement, but it would be better to re-factor the UserMerge
> page into a FormSpecialPage. It helps to get rid of repeated code and can
> also
> make validation automatic.

Good idea, but for later. I need to fix other issues in other extensions first, This is why I did not set "assigned".
Comment 2 Tyler Romeo 2013-06-13 08:39:00 UTC 
Yep, I figured. Just wanted to catalog it as a long-term goal.
Comment 3 T. Gries 2014-06-12 07:02:06 UTC 
Legoktm: this code-beautifying is a long-term goal. It is not as urgent as the other E:UserMergge issues you mentioned recently (Yes, I follow them, thanks, and will review soon. ETA ~2 weeks).
Comment 4 Gerrit Notification Bot 2014-06-12 07:17:40 UTC 
Change 139076 had a related patch set uploaded by Legoktm:
Use FormSpecialPage

https://gerrit.wikimedia.org/r/139076
Comment 5 Gerrit Notification Bot 2014-07-09 21:36:11 UTC 
Change 139076 merged by jenkins-bot:
Use FormSpecialPage

https://gerrit.wikimedia.org/r/139076
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links