Last modified: 2014-06-12 01:33:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51520, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49520 - Performance: Update text and ID fields simultaneously
Performance: Update text and ID fields simultaneously
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UserMerge (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Tyler Romeo
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-13 08:22 UTC by Tyler Romeo
Modified: 2014-06-12 01:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tyler Romeo 2013-06-13 08:22:58 UTC
Right now UserMerge::mergeUser() updates ID fields (e.g., ar_user) and text fields (e.g., ar_user_text) in separate queries. Considering ar_user and ar_user_text should be exactly the same for a logged in user, you could cut the number of DB queries in half by combining them. For large wikis, this may save a significant amount of time since it doesn't have to scan each table twice.
Comment 1 T. Gries 2013-06-13 15:10:04 UTC
just a suggestion to the bug listeners: 

perhaps someone of you can help and recode the specific subroutine UserMerge::mergeUser() in the proposed way, I am sure you can code this more elegant and quickly than I can do.

anyway: I noted your valid point, the db access should be improved in this old code.

Be reminded that I am not the maintainer or project owner of that extension (I placed a request, but this wasn't accepted yet.)
Comment 2 Gerrit Notification Bot 2013-06-16 21:45:09 UTC
Related URL: https://gerrit.wikimedia.org/r/69017 (Gerrit Change Ibb36ef49e99246e502835f51ab6776422b62438d)
Comment 3 Kunal Mehta (Legoktm) 2014-06-12 01:33:04 UTC
Patch was merged nearly a year ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links