Last modified: 2013-06-24 21:38:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51563, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49563 - VisualEditor: Section edit link behaviour tweaks
VisualEditor: Section edit link behaviour tweaks
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-06-27
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-14 03:21 UTC by James Forrester
Modified: 2013-06-24 21:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-06-14 03:21:26 UTC
Clicking the section edit link into VE has three minor issues:

* The cursor is positioned at the start of the heading of that section; it should probably go to the start of the next element straight after the section (in most cases, a paragraph)
* The page doesn't actually scroll to the correct area; ideally the page should be deliberately scrolled to that section (as it happens, you normally end up on roughly the right part because the page is already scrolled, but there are cases where VE pages are lengthier or shorter than PHP pages and so this can't be relied upon).
* The toolbar only appears once you scroll (because it's triggered on page movement, and the page doesn't move at first to get to the section because it's already there) - this means that it suddenly pops into view a bit too late.
Comment 1 Gerrit Notification Bot 2013-06-24 18:55:28 UTC
Related URL: https://gerrit.wikimedia.org/r/70229 (Gerrit Change I3a57e64f54289a3263814b4fbfe00c63de4a490b)
Comment 2 Ed Sanders 2013-06-24 18:58:55 UTC
^^^ Fixes scroll
Comment 3 Gerrit Notification Bot 2013-06-24 19:23:33 UTC
Related URL: https://gerrit.wikimedia.org/r/70238 (Gerrit Change I6fcc463aeeae40278f5caf04ae251c8ecfe65472)
Comment 4 Ed Sanders 2013-06-24 19:26:25 UTC
^^^ Moves cursor to next non-heading
Comment 5 Ed Sanders 2013-06-24 19:27:59 UTC
#3 in your list is fixed by #2
Comment 6 James Forrester 2013-06-24 21:38:21 UTC
Both changes merged, so marking as fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links