Last modified: 2013-06-17 19:00:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51566, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49566 - Buffer ParserService output
Buffer ParserService output
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-14 05:56 UTC by Gabriel Wicke
Modified: 2013-06-17 19:00 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-06-14 05:56:13 UTC
We currently write out results straight to the response, which makes it impossible to properly handle and report errors once the headers are sent. 
Instead we should buffer the full output before writing it to the response. 

This is especially important as we are now caching out output aggressively, and we don't want to cache partial output. The VE also gets a truncated 200 OK response on such mid-write failures which will surely mess up round-tripping.
Comment 1 Gerrit Notification Bot 2013-06-14 23:11:52 UTC
Related URL: https://gerrit.wikimedia.org/r/68818 (Gerrit Change I944558d265b6329a87499ef9a38b4c5b9e34ca8f)
Comment 2 Gerrit Notification Bot 2013-06-17 17:51:44 UTC
https://gerrit.wikimedia.org/r/68818 (Gerrit Change I944558d265b6329a87499ef9a38b4c5b9e34ca8f) | change APPROVED and MERGED [by jenkins-bot]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links