Last modified: 2013-06-23 15:45:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51596, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49596 - VisualEditor: Adding a file/media fails with wrong wikicode (Image insertion sets resource='undefined')
VisualEditor: Adding a file/media fails with wrong wikicode (Image insertion ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Highest major
: VE-deploy-2013-06-20
Assigned To: Ed Sanders
https://test.wikipedia.org/w/index.ph...
:
: 49795 49829 50021 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-14 21:18 UTC by Raimond Spekking
Modified: 2013-06-23 15:45 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2013-06-14 21:18:48 UTC
Adding a file/media fails with wrong wikicode.

This wikicode is created, see URL:

[[undefined|link=https://commons.wikimedia.org/wiki/File:CV.03326.jpg|right|framed|424x275px]]
Comment 1 James Forrester 2013-06-14 21:21:00 UTC
Roan, do we get the typeof:/etc. wrong at our end, or is this a Parsoid issue?
Comment 3 goethe.wiki 2013-06-16 13:59:17 UTC
I get the same type of error: <http://pt.wikipedia.org/w/index.php?title=PLoS_ONE&diff=36119075&oldid=34872658>
Comment 4 This, that and the other (TTO) 2013-06-19 07:42:33 UTC
*** Bug 49795 has been marked as a duplicate of this bug. ***
Comment 5 Helder 2013-06-19 11:20:50 UTC
(In reply to comment #3)
> I get the same type of error:
> <http://pt.wikipedia.org/w/index.
> php?title=PLoS_ONE&diff=36119075&oldid=34872658>

On this example there is also something else: I think the code "direita,right" should be just "direita" or "right".
Comment 6 tm112 2013-06-19 13:30:53 UTC
The same on plwiki: https://pl.wikipedia.org/w/index.php?diff=36790309
("prawo" means "right" in polish, "ramka" means "frame")
Comment 7 James Forrester 2013-06-19 16:30:07 UTC
*** Bug 49829 has been marked as a duplicate of this bug. ***
Comment 8 James Forrester 2013-06-19 16:31:36 UTC
From bug 49829 comment 0:

| This is the DOM returned by the VE after inserting a new thumbnail:
| <figure typeof="mw:Image/Frame" class=" mw-halign-right">
| <a rel="mw:thumb" href="http://commons.wikimedia.org/wiki/File:Apples.jpg">
| <img src="http://upload.wikimedia.org/wikipedia/commons/thumb/e/ee/Apples.jpg/
|   100px-Apples.jpg" width="100" height="150" resource="undefined"></a></figure>
| 
| Note the 'undefined' in the resource attribute. The resource is the image
| target, so we notice that the link and the image named 'undefined' differ and
| serialize as
| [[undefined|link=http://commons.wikimedia.org/wiki/File:Apples.jpg|thumb]].
Comment 9 James Forrester 2013-06-19 22:46:49 UTC
This is partially fixed in Gerrit change #69581 which we will deploy this afternoon.

However, the link issue is still not fixed, thus (in the example in comment 0) we will now get:

[[File:CV.03326.jpg|link=https://commons.wikimedia.org/wiki/File:CV.03326.jpg|right|framed|424x275px]]

… instead of:

[[File:CV.03326.jpg|right|framed|424x275px]]

… which is bad, but nothing like as terrible as it was. Forking that off to a new bug, bug 49844, and marking this as fixed.
Comment 10 Helder 2013-06-19 23:29:07 UTC
What about commend 5 and comment 6?
Comment 11 James Forrester 2013-06-20 01:13:05 UTC
(In reply to comment #10)
> What about commend 5 and comment 6?

Sorry, yes; created as bug 49849.
Comment 12 James Forrester 2013-06-23 15:45:31 UTC
*** Bug 50021 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links