Last modified: 2013-06-16 21:48:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51601, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49601 - VisualEditor: Swallowing of empty text annotations leads to dirty diffs and unexpected Parsoid normalisation
VisualEditor: Swallowing of empty text annotations leads to dirty diffs and u...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-06-13
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-15 01:10 UTC by Matthew Flaschen
Modified: 2013-06-16 21:48 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-06-15 01:10:31 UTC
VisualEditor caused this dirty diff (https://en.wikipedia.org/w/index.php?title=List_of_South_Korean_idol_groups_%282010s%29&diff=559356009&oldid=559228059) when editing a table.  Note the removal of the empty small elements, and the change to the align syntax.
Comment 1 James Forrester 2013-06-16 21:48:10 UTC
(In reply to comment #0)
> VisualEditor caused this dirty diff
> (https://en.wikipedia.org/w/index.
> php?title=List_of_South_Korean_idol_groups_%282010s%29&diff=559356009&oldid=5
> 59228059)
> when editing a table.  Note the removal of the empty small elements, and the
> change to the align syntax.

The removal of empty text annotations has been fixed as of wmf7 (Gerrit change #68213 and Gerrit change #68190), which is now deployed a week early on enwiki to fix this and other issues - sorry about that. This will stop "the removal of the empty small elements", and consequently the changes to the table syntax that Parsoid does on lines that aren't otherwise changed.

The non-semantic syntactical change of the HTML syntax is, I believe intentionally  done by Parsoid to normalise the wikitext; it is only done on lines of wikitext that are changed anyway by user action (unless there's a bug in VisualEditor which causes the contents of the HTML to change unexpectedly, as was the case here).

Consequently marking as "fixed".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links