Last modified: 2013-10-03 21:29:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51629, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49629 - thumb.php uses hook ExtractThumbParameters instead of the relavent MediaHandler::parseParamString
thumb.php uses hook ExtractThumbParameters instead of the relavent MediaHandl...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-16 03:36 UTC by Bawolff (Brian Wolff)
Modified: 2013-10-03 21:29 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bawolff (Brian Wolff) 2013-06-16 03:36:20 UTC 
thump.php seems to use its own hook for parsing image param string (Introduced dcbe8e7dd3), instead of using the media handlers parseParamString method. This is confusing, and I'm not sure why it does this.
Comment 1 Jarry1250 2013-06-16 21:43:50 UTC 
At the moment, wfExtractThumbParams() just takes a string and then does stuff to that string -- it's very lightweight. I guess that's why they didn't go for fancy MIME detection/object instantiation which might be memory intensive.
Comment 2 Jarry1250 2013-06-16 21:51:11 UTC 
Also, the Apache code for redirecting requests for non-existent thumbs to thumb.php will need to be adjusted; AFAIK at the moment it includes a manual list of permutations.
Comment 3 Jarry1250 2013-06-16 21:59:21 UTC 
...or maybe not, if that's what rewrite.py does. Not sure to be honest, bit out of my depth.
Comment 4 Gerrit Notification Bot 2013-06-16 22:25:40 UTC 
Related URL: https://gerrit.wikimedia.org/r/69019 (Gerrit Change I3e703c84ff84e30d8b96acf491318829767eb2ab)
Comment 5 Gerrit Notification Bot 2013-06-17 03:07:17 UTC 
Related URL: https://gerrit.wikimedia.org/r/69027 (Gerrit Change I43a0e7d6f0e45536e4e24b72140157791f5f027f)
Comment 6 Gerrit Notification Bot 2013-09-30 18:11:11 UTC 
Change 69027 merged by jenkins-bot:
Make thumb_handler.php use MediaHandler::parseParamString

https://gerrit.wikimedia.org/r/69027
Comment 7 Bawolff (Brian Wolff) 2013-10-03 21:29:54 UTC 
Confirmed fixed: https://test.m.wikipedia.org/wiki/File:Gerrit_patchset_25838_test.svg?lang=de
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links