Last modified: 2013-06-18 19:42:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51630, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49630 - VisualEditor: Closing (as opposed to applying) a dialog with no changes undoes last item in the stack anyway
VisualEditor: Closing (as opposed to applying) a dialog with no changes undoe...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-06-20
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-16 04:12 UTC by MZMcBride
Modified: 2013-06-18 19:42 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-06-16 04:12:38 UTC
https://en.wikipedia.org/wiki/Digital_Forensics_XML?veaction=edit

I went there, I changed a header from h3 to h2 by selecting the header and using the drop-down menu. When I click "Page settings" and then close the dialog box without making any changes, my change to the header is inexplicably lost.
Comment 1 James Forrester 2013-06-17 01:05:46 UTC
This looks like the code to "undo changes made in the dialog when they don't apply them" is doing that once too often.
Comment 2 Ed Sanders 2013-06-18 15:57:49 UTC
Not quite, it's just doing it without checking if a new breakpoint was actually added.
Comment 3 Gerrit Notification Bot 2013-06-18 15:58:31 UTC
Related URL: https://gerrit.wikimedia.org/r/69316 (Gerrit Change Ieb2e9e361afe057af93c4d374acc85df58bfb4c3)
Comment 4 James Forrester 2013-06-18 19:42:07 UTC
Merged and will go out with wmf8.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links