Last modified: 2014-04-15 20:14:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51636, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49636 - [mediawiki.feedback.js] MediaWiki's "feedback" tool fails badly when it can't write to the target page
[mediawiki.feedback.js] MediaWiki's "feedback" tool fails badly when it can't...
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.22.0
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/MLEB
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-16 11:37 UTC by Niklas Laxström
Modified: 2014-04-15 20:14 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of the issue (168.69 KB, image/png)
2013-06-16 11:37 UTC, Niklas Laxström
Details

Description Niklas Laxström 2013-06-16 11:37:47 UTC
Created attachment 12552 [details]
Screenshot of the issue

1) Go to http://www.mediawiki.org/wiki/MLEB
2) Click edit section for Add/update your LocalSettings.php

Observed: Page scrolls up and some very different section is hihglighted. No editor chrome is shown. (Is there a bug for this?)

3) Scroll down back to the section named above

Observed: Cannot edit the syntaxhighlighted block
Observed: Editor chrome appears

4) Click beta on the toolbar
5) Click leave feedback

Observed: page is dimmed and otherwise unfunctional and nothing can be done. See attached screenshot.
Comment 1 James Forrester 2013-06-16 23:08:54 UTC
The proximate cause of this is that the (MediaWiki core!) feedback tool is pointed at a page that is protected, and it doesn't fail nicely.

More generally, the problem is that the target page is an LQT page, and LQT doesn't intercept section=new through the API, only through the skin interface, so these feedback items are mis-directed. See 41276.

I'm unprotecting the target LQT section header again, though this is not very much more helpful for all concerned. :-(
Comment 2 Bawolff (Brian Wolff) 2013-06-16 23:18:11 UTC
(In reply to comment #1)
> The proximate cause of this is that the (MediaWiki core!) feedback tool is
> pointed at a page that is protected, and it doesn't fail nicely.
> 

You're sure that that is MediaWiki core. /me is unaware of any feedback tool in mediawiki core.
Comment 3 James Forrester 2013-06-16 23:35:47 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > The proximate cause of this is that the (MediaWiki core!) feedback tool is
> > pointed at a page that is protected, and it doesn't fail nicely.
> > 
> 
> You're sure that that is MediaWiki core. /me is unaware of any feedback tool
> in mediawiki core.

MediaWiki/core.git -> /resources/mediawiki/mediawiki.feedback.js:

https://git.wikimedia.org/blob/mediawiki%2Fcore.git/6a3bc6294a1b5b42a4d0f7062152d892e0aed1d3/resources%2Fmediawiki%2Fmediawiki.feedback.js

Always surprised how few people know about it, given how key it was for the Vector roll-out.
Comment 4 Bawolff (Brian Wolff) 2013-06-17 00:25:54 UTC
With precisely 0 uses in core :P
Comment 5 James Forrester 2013-06-17 00:28:59 UTC
(In reply to comment #4)
> With precisely 0 uses in core :P

That's Platform's call, not mine. :-)
Comment 6 Nemo 2013-06-17 06:51:30 UTC
(In reply to comment #3)
> Always surprised how few people know about it, given how key it was for the
> Vector roll-out.

For the records, <https://meta.wikimedia.org/wiki/Vector#How_can_I_give_feedback_about_the_new_skin.3F> I guess.
The feedback page(s) had a mere hundred edits? It's not surprising they weren't noticed <http://vs.aka-online.de/cgi-bin/wppagehiststat.pl?lang=meta.wikimedia&page=2010+Wikimedia+design+and+feature+change%2FFeedback>
(And I now see I even helped process the feedback there...)
Comment 7 ganeshaditya1 2014-04-05 19:36:41 UTC
Can't see the beta button no more.
Comment 8 James Forrester 2014-04-15 20:14:20 UTC
(In reply to ganeshaditya1 from comment #7)
> Can't see the beta button no more.

Yes, the 'beta' button that this referred to last June no longer exists, but you can still get to the feedback form inside VE from the 'help' menu.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links