Last modified: 2014-04-25 16:50:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51688, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49688 - Parsoid chokes on unescaped single quotes in URLs
Parsoid chokes on unescaped single quotes in URLs
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-17 11:45 UTC by Oliver Keyes
Modified: 2014-04-25 16:50 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-06-17 11:45:43 UTC
See https://en.wikipedia.org/wiki/United_States_v._11_1/4_Dozen_Packages_of_Articles_Labeled_in_Part_Mrs._Moffat%27s_Shoo-Fly_Powders_for_Drunkenness - with the last link ([http://archive.nlm.nih.gov/fdanj/items-by-subject?subject=Mrs.+Moffat's+Shoo+Fly+Powders+for+Drunkenness Case information at the NIH National Library of Medicine]) the VE incorrectly determines which bit is the URL and which is the displayed text, resulting in (within the VE) page text that reads "'s+Shoo+Fly+Powders+for+Drunkenness Case information at the NIH National Library of Medicine"
Comment 1 Oliver Keyes 2013-06-17 11:54:31 UTC
Possibly another instance at https://en.wikipedia.org/wiki/Acromantis_formosana?veaction=edit although this may be unrelated.
Comment 2 James Forrester 2013-06-21 20:43:55 UTC
A Parsoid issue, though really it's a very messy URL.

Example breaking wikitext:

[http://example.org/Foo'bar No bar in title]

Should be:

<p data-parsoid="…"><a rel="mw:ExtLink" href="http://example.org/Foo'bar" data-parsoid="…">No bar in title</a></p>

Instead is:

<p data-parsoid="…"><a rel="mw:ExtLink" href="http://example.org/Foo" data-parsoid="…">'bar No bar in title</a></p>
Comment 3 Andre Klapper 2013-07-04 10:35:10 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Comment 4 Gerrit Notification Bot 2014-04-23 17:12:33 UTC
Change 126853 had a related patch set uploaded by Cscott:
Fix a number of link-parsing and serialization issues.

https://gerrit.wikimedia.org/r/126853
Comment 5 Gerrit Notification Bot 2014-04-24 19:58:10 UTC
Change 126853 merged by jenkins-bot:
Fix a number of link-parsing and serialization issues.

https://gerrit.wikimedia.org/r/126853

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links