Last modified: 2013-06-17 19:38:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51691, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49691 - VisualEditor: Tables with a faulty <tr> at their end display it, confusing users
VisualEditor: Tables with a faulty <tr> at their end display it, confusing users
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-17 11:57 UTC by Oliver Keyes
Modified: 2013-06-17 19:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-06-17 11:57:07 UTC
See https://en.wikipedia.org/wiki/Daryle_Singletary?veaction=edit - the first three (but strangely, not the last) discography tables.
Comment 1 James Forrester 2013-06-17 19:17:19 UTC
This is not a bug (well, it's not a bug with VE :-)) - the three "broken" tables all have 

  |-
  | <content>
  |-
  |}

… at the end, which is not the case for the third "working" one. What you see is the result of broken wikitext.

VE is good, but it can't be psychic about what you wanted to do with that that extra table row (maybe you wanted to expand the table and were half-way through?) so behaviour is "as intended". Marking as INVALID; in general broken wikitext like this can't be trivially fixed by a bot, due to wikitext's complexities, but it might be worth exploring.
Comment 2 Oliver Keyes 2013-06-17 19:23:39 UTC
Makes sense. Alternately would it be possible to add it in as a rule to Parsoid's voodo wikimarkup-fixing stuff? If a |- is followed by nothing and then a |}...
Comment 3 James Forrester 2013-06-17 19:25:09 UTC
(In reply to comment #2)
> Makes sense. Alternately would it be possible to add it in as a rule to
> Parsoid's voodo wikimarkup-fixing stuff? If a |- is followed by nothing and
> then a |}...

But some gadgets might rely on that meaning something special for some users. Everything we change or "fix" potentially breaks things for some (other) users. :-(
Comment 4 Roan Kattouw 2013-06-17 19:29:13 UTC
This is a Parsoid bug. The PHP parser does not generate a <tr> for this wikitext, and Parsoid does.
Comment 5 James Forrester 2013-06-17 19:31:06 UTC
(In reply to comment #4)
> This is a Parsoid bug. The PHP parser does not generate a <tr> for this
> wikitext, and Parsoid does.

Does the PHP parser create it but it then gets tidied away?
Comment 6 Roan Kattouw 2013-06-17 19:38:05 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > This is a Parsoid bug. The PHP parser does not generate a <tr> for this
> > wikitext, and Parsoid does.
> 
> Does the PHP parser create it but it then gets tidied away?
That's possible, I haven't checked what happens when Tidy is disabled.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links