Last modified: 2013-09-04 21:25:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51711, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 49711 - Check why DSR on DOMFragment wrappers is sometimes missing


Summary:	Check why DSR on DOMFragment wrappers is sometimes missing

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	DOM (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-06-17 19:20 UTC by Gabriel Wicke
Modified:	2013-09-04 21:25 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-06-17 19:20:41 UTC

In unpackDOMFragment, we sometimes get wrappers without DSR:

			var dsr = node.data.parsoid.dsr;
			// FIXME: Not sure why this would be missing
			if (dsr) {
				firstChild.data.parsoid.dsr = [dsr[0], dsr[1]];
			}

We should really track down when and why this is the case. A list of pages with this issue is exposed in http://parsoid.wmflabs.org:8001/topfixes/between/c28f13708fe1643acea1ed871182b2a0797b1c45/d1ae92720c4eaee391b324d566f7b91f84e72b7e.

Comment 1 Gerrit Notification Bot 2013-06-29 05:04:48 UTC

Change 71166 had a related patch set uploaded by GWicke:
Bug 49711: Add debug print when dsr on wrapper is missing

https://gerrit.wikimedia.org/r/71166

Comment 2 Gerrit Notification Bot 2013-06-29 05:28:57 UTC

Change 71166 merged by jenkins-bot:
Bug 49711: Add debug print when dsr on wrapper is missing

https://gerrit.wikimedia.org/r/71166

Comment 3 Gabriel Wicke 2013-09-04 21:25:59 UTC

This does not seem to happen any more in production, and the old parser test results are no longer accessible after the rt testing migration to MySQL. Closing this as presumably fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links