Last modified: 2013-06-18 07:46:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51727, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49727 - Account Creation leaves broken unusable accounts due to VisualEditorHooks::onAddNewAccount
Account Creation leaves broken unusable accounts due to VisualEditorHooks::on...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Immediate critical
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-18 02:48 UTC by Cyberpower678
Modified: 2013-06-18 07:46 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Cyberpower678 2013-06-18 02:48:00 UTC
Ok.  Here's the diagnosis.  Any attempt to create the account returns a "Fatal exception of type MWException".  The account and SUL get created but, email and password get left out.  Essentially, the user can't login with the password set or provided by email.  Nor can they confirm email and use it to reset the password.  This essentially leaves a corrupted, unusable account.  Replicating it is easy, just try to create an account.
Comment 1 Steven Walling 2013-06-18 02:53:22 UTC
Confirmed. I get "[76812464] 2013-06-18 02:51:53: Fatal exception of type MWException" when trying to create any account on enwiki, but I receive the correct email confirmation message.
Comment 2 Cyberpower678 2013-06-18 02:54:31 UTC
(In reply to comment #1)
> Confirmed. I get "[76812464] 2013-06-18 02:51:53: Fatal exception of type
> MWException" when trying to create any account on enwiki, but I receive the
> correct email confirmation message.

You do get an email confirmation message, but the email is not attached to the account.  I confirmed this several times.
Comment 3 Matthew Flaschen 2013-06-18 02:55:42 UTC
I'll investigate.
Comment 4 Andre Klapper 2013-06-18 02:57:44 UTC
Also confirming:
1. Create an account on en.wikipedia.org and enter data
2. Get "[1903eff7] 2013-06-18 02:39:00: Fatal exception of type MWException" directly after
3. Click link in upper corner to go to your userpage
4. Get: User account "foo" is not registered.

[22:31] <+Cyberpower678> Ok.  Here's the diagnosis.  Any attempt to create the account returns a "Fatal exception of type MWException".  The account and SUL get created but, email and password get left out.  Essentially, the user can't login with the password set or provided by email.  Nor can they confirm email and use it to reset the password.
Comment 5 spage 2013-06-18 03:07:35 UTC
On fluorine, /a/mw-log/exception.log has

/w/index.php?title=Special:UserLogin&action=submitlogin&type=signup&returnto=Main+Page   Exception from line 215 of /usr/local/apache/common-local/php-1.22wmf6/includes/Hooks.php: Detected bug in an extension! Hook VisualEditorHooks::onAddNewAccount failed to return a value; should return true to continue hook processing or false to abort.

should be an easy fix for wmf6?
Comment 6 Cyberpower678 2013-06-18 03:14:02 UTC
It looks like this bug creates SUL errors too.  See User:ChrisWittGeorge as an example of it supposedly not existing but when trying to create on Meta, it claims that there is an SUL.
Comment 7 Matthew Flaschen 2013-06-18 03:16:18 UTC
Fixed as a prod-only patch, will do proper Gerrit shortly.
Comment 8 Andre Klapper 2013-06-18 03:17:48 UTC
Full patch by mtraceur: https://gerrit.wikimedia.org/r/#/c/69277/
Comment 9 Steven Walling 2013-06-18 03:20:49 UTC
(In reply to comment #7)
> Fixed as a prod-only patch, will do proper Gerrit shortly.

Fix is working for me.
Comment 10 Cyberpower678 2013-06-18 03:21:54 UTC
(In reply to comment #6)
> It looks like this bug creates SUL errors too.  See User:ChrisWittGeorge as
> an
> example of it supposedly not existing but when trying to create on Meta, it
> claims that there is an SUL.

Can these lingering SUL bugs be fixed too, if any?
Comment 11 Ori Livneh 2013-06-18 03:31:24 UTC
Merged & deployed. Thanks S, Matthew.

> Can these lingering SUL bugs be fixed too, if any?

This bug was simple: a hook wasn't returning a value. If the fix fixes it, great. If not, it wasn't caused by this bug in the first place.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links