Last modified: 2013-09-03 16:24:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51729, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49729 - Parsoid: DSR on DOM of some reused images is buggy (causing image fragments to be duplicated on save on some pages)
Parsoid: DSR on DOM of some reused images is buggy (causing image fragments t...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
DOM (Other open bugs)
unspecified
All All
: High major
: ---
Assigned To: ssastry
:
: 49824 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-18 05:15 UTC by Oliver Keyes
Modified: 2013-09-03 16:24 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-06-18 05:15:09 UTC
See https://en.wikipedia.org/w/index.php?title=Star_Trek_Into_Darkness&diff=560374167&oldid=560361644 - without changing or going near the link, it ended up hamfistedly duplicated on save.
Comment 1 Oliver Keyes 2013-06-18 18:52:50 UTC
Most recently seen at https://en.wikipedia.org/w/index.php?title=User%3AEdgepedia%2FVE%2FMet&diff=560486146&oldid=560485453 - still there after the latest deploy, and going to be highly disruptive to popular (read: also probably very long, and image-filled) articles.
Comment 2 Oliver Keyes 2013-06-18 19:35:58 UTC
Appeared again at https://en.wikipedia.org/w/index.php?title=User%3AEdgepedia%2FVE%2FMet&diff=560495770&oldid=560486146 - this was an attempt to resize an image. Possibly the source? Investigating further.
Comment 3 Oliver Keyes 2013-06-19 10:03:46 UTC
Upping to major, because it's also happening with (eg) typo corrections - https://en.wikipedia.org/w/index.php?title=Bombardier_CSeries&diff=prev&oldid=560579191
Comment 4 ssastry 2013-06-19 11:25:40 UTC
Same cause as https://bugzilla.wikimedia.org/show_bug.cgi?id=49655, but this time on images.

Ex: dsr":[20586,20590] on the sole image in https://en.wikipedia.org/w/index.php?title=Star_Trek_Into_Darkness

Fix coming -- to be tested, reviewed, and merged later today. All parsoid varnishes should be purged again.  

This should be the last instance of bugs from reusing cached DOM fragments. 49655 fixed this for templates and extensions. This should fix it for images.
Comment 5 Gerrit Notification Bot 2013-06-19 11:41:36 UTC
Related URL: https://gerrit.wikimedia.org/r/69477 (Gerrit Change Id6d7de70cecf6d5d9e79e2f9875a271487916dbe)
Comment 6 Gerrit Notification Bot 2013-06-19 15:52:16 UTC
https://gerrit.wikimedia.org/r/69477 (Gerrit Change Id6d7de70cecf6d5d9e79e2f9875a271487916dbe) | change APPROVED and MERGED [by jenkins-bot]
Comment 7 ssastry 2013-06-19 20:23:06 UTC
Seems partially fixed -- the egregious duplication issues seem to be gone.

But, I am seeing a different issue on https://en.wikipedia.org/wiki/Bombardier_CSeries after I made a minor edit. 

Reviewing diffs on subsequent edits reveals bad wikitext changes (off-by-1-char) on one image. Looking at the HTML for that figure shows off-by-1 TSR and DSR values on pieces of that image which messes up the serialiation from that HTML.
Comment 8 Gerrit Notification Bot 2013-06-19 22:33:18 UTC
Related URL: https://gerrit.wikimedia.org/r/69597 (Gerrit Change I32c511d05d62dd31bb19fca21aff792ddc422331)
Comment 9 Gerrit Notification Bot 2013-06-19 22:33:21 UTC
Related URL: https://gerrit.wikimedia.org/r/69597 (Gerrit Change I32c511d05d62dd31bb19fca21aff792ddc422331)
Comment 10 Gerrit Notification Bot 2013-06-19 23:51:27 UTC
https://gerrit.wikimedia.org/r/69597 (Gerrit Change I32c511d05d62dd31bb19fca21aff792ddc422331) | change APPROVED and MERGED [by jenkins-bot]
Comment 11 This, that and the other (TTO) 2013-06-20 09:43:28 UTC
*** Bug 49824 has been marked as a duplicate of this bug. ***
Comment 12 ssastry 2013-06-20 18:20:36 UTC
All the fixes for this have been deployed and caches purged of stale HTML. Could you all test independently and verify that the problems have been fixed before we close this out?
Comment 13 ssastry 2013-06-20 22:40:37 UTC
My testing on a couple pages shows that this is fixed.  Closing.  Please reopen if necessary.
Comment 14 Elitre 2013-08-31 12:03:23 UTC
Ssastry, I am afraid this is back, see https://it.wikipedia.org/w/index.php?title=Dalmine&diff=61238476&oldid=61238456 . The user just added a wikilink - which is how you can reproduce the problem, the code is already corrupted in the preview.
Comment 15 ssastry 2013-09-03 16:24:35 UTC
No, this is bug 53071.  I'll add this as another example of that bug and we'll try to get that bug fixed this week.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links