Last modified: 2013-06-20 00:47:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51751, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49751 - Ajax "This file already exists" doesn't load image related js (e.g. from TMH)
Ajax "This file already exists" doesn't load image related js (e.g. from TMH)
Status: NEW
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.22.0
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-18 15:21 UTC by Bawolff (Brian Wolff)
Modified: 2013-06-20 00:47 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2013-06-18 15:21:10 UTC
Goto special:Upload, put in a file name that's an already existing TMH file. The "This file already exists" ajax warning doesn't load the js player, and falls back to native browser <audio> or <video> element.

Fairly minor issue, that may be difficult to fix, but ideally wouldn't happen.
Comment 1 Michael Dale 2013-06-18 15:26:27 UTC
We support dynamic loading of the player, so we should be able to fix this.
Comment 2 Bawolff (Brian Wolff) 2013-06-18 15:36:49 UTC
(In reply to comment #1)
> We support dynamic loading of the player, so we should be able to fix this.

I'm more thinking from the perspective that the interface on the MW core side is kind of klunky. OTOH, if the last remaining use of $wgAjaxExportList in core was removed and replaced with something better, I imagine that would make people happy for entirely other reasons.
Comment 3 Michael Dale 2013-06-18 15:39:49 UTC
MwEmbed modules include "loaders" that have some minimal code for invoking the async loading of all the components needed. i.e:  we always export a $.fn.embedPlayer method[1] that can be run as soon as the video tag is in the DOM. 

[1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTimedMediaHandler/1864d1801f433562ce3e53a443d3f3196206b29a/MwEmbedModules%2FEmbedPlayer%2FEmbedPlayer.loader.js#L31
Comment 4 Alex Monk 2013-06-18 16:05:00 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > We support dynamic loading of the player, so we should be able to fix this.
> 
> I'm more thinking from the perspective that the interface on the MW core side
> is kind of klunky. OTOH, if the last remaining use of $wgAjaxExportList in
> core
> was removed and replaced with something better, I imagine that would make
> people happy for entirely other reasons.

I tried to do this in Gerrit change #65641

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links