Last modified: 2013-07-11 00:37:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51755, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49755 - VisualEditor: Nested identical annotations can be additive, not just identical
VisualEditor: Nested identical annotations can be additive, not just identical
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High minor
: VE-deploy-2013-07-11
Assigned To: Ed Sanders
https://en.wikipedia.org/w/index.php?...
:
: 49756 (view as bug list)
Depends on: 50604
Blocks: 50549
  Show dependency treegraph
 
Reported: 2013-06-18 16:56 UTC by James Forrester
Modified: 2013-07-11 00:37 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-06-18 16:56:25 UTC
<b><b>Foo</b></b> == <b>Foo</b> so it's not /so/ bad if VE corrects it (but it's still a bit dirty, but <small><small>Foo</small></small> != <small>Foo</small> (and the same with <big> and <sup> and …)
Comment 1 Oliver Keyes 2013-06-18 16:57:24 UTC
*** Bug 49756 has been marked as a duplicate of this bug. ***
Comment 2 Gabriel Wicke 2013-07-02 00:06:59 UTC
This causes round-trip failures.
Comment 3 Gerrit Notification Bot 2013-07-02 20:25:24 UTC
Change 71716 had a related patch set uploaded by Esanders:
Allow annotations to be additive

https://gerrit.wikimedia.org/r/71716
Comment 4 Ed Sanders 2013-07-02 20:30:53 UTC
The fix sets big/small/sup/sub to be additive.

Arguably we should make all annotations additive, as you could add 'style="font-size:110%"' to anything, although I haven't thought through how this might affect the toolbar interactions yet.
Comment 5 Gerrit Notification Bot 2013-07-02 20:46:12 UTC
Change 71716 merged by jenkins-bot:
Allow annotations to be additive

https://gerrit.wikimedia.org/r/71716
Comment 6 Gabriel Wicke 2013-07-02 21:48:43 UTC
(In reply to comment #4)
> The fix sets big/small/sup/sub to be additive.
> 
> Arguably we should make all annotations additive, as you could add
> 'style="font-size:110%"' to anything, although I haven't thought through how
> this might affect the toolbar interactions yet.

+1. This will also avoid dirty diffs on such content.
Comment 7 Gerrit Notification Bot 2013-07-05 20:19:42 UTC
Change 72133 had a related patch set uploaded by Esanders:
Make all annotations additive

https://gerrit.wikimedia.org/r/72133
Comment 8 Gerrit Notification Bot 2013-07-08 19:51:58 UTC
Change 72133 merged by jenkins-bot:
Make all annotations additive

https://gerrit.wikimedia.org/r/72133
Comment 9 James Forrester 2013-07-08 21:25:42 UTC
Fixed on the VisualEditor side; the Parsoid upstream issue in Domino is patched but not yet released. Not marking as fixed until that's done.
Comment 10 James Forrester 2013-07-11 00:37:58 UTC
Now fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links