Last modified: 2013-06-20 21:44:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51765, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49765 - Newlines after comments don't round-trip
Newlines after comments don't round-trip
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-18 19:13 UTC by Gabriel Wicke
Modified: 2013-06-20 21:44 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-06-18 19:13:01 UTC 
Test cases:
echo -e '<!-- comment -->\n\n\nfoo' | node parse --wt2wt
echo -e '<!-- comment -->\n\nfoo' | node parse --wt2wt

This might be solvable by relaxing the newline separator constraints if the previousSiblings are newlines preceded by a bare comment.
Comment 1 Gabriel Wicke 2013-06-18 19:14:50 UTC 
Increasing priority as this is not hidden by selective serialization if any of the siblings of this parent are modified.
Comment 2 ssastry 2013-06-20 21:34:52 UTC 
Patch in gerrit: https://gerrit.wikimedia.org/r/#/c/69795/
Comment 3 Gerrit Notification Bot 2013-06-20 21:42:50 UTC 
https://gerrit.wikimedia.org/r/69795 (Gerrit Change Ifa13f93906f09c6d7d019e6b652d11fa48ca2420) | change APPROVED and MERGED [by jenkins-bot]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links