Last modified: 2013-07-04 10:34:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51766, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49766 - Parsoid should join adjacent <b> tags and the like
Parsoid should join adjacent <b> tags and the like
Status: RESOLVED DUPLICATE of bug 48194
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-18 19:30 UTC by Roan Kattouw
Modified: 2013-07-04 10:34 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-06-18 19:30:56 UTC
$ echo "'''Foo'''Bar'''Baz'''" | node parse.js --wt2html | tee foobarbaz
<body><p data-parsoid='{"dsr":[0,21,0,0]}'><b data-parsoid='{"dsr":[0,9,3,3]}'>Foo</b>Bar<b data-parsoid='{"dsr":[12,21,3,3]}'>Baz</b></p>
</body>

# Edit text to remove Bar, round-trip back
$ cat foobarbaz
<body><p data-parsoid='{"dsr":[0,21,0,0]}'><b data-parsoid='{"dsr":[0,9,3,3]}'>Foo</b><b data-parsoid='{"dsr":[12,21,3,3]}'>Baz</b></p>
</body>

$ cat foobarbaz | node parse.js --html2wt
'''Foo''''''Baz'''


The expected output is '''FooBaz'''.

Right now this works correctly because VE joins the adjacent <b> tags and sends Parsoid <b data-parsoid='{"dsr":[0,9,3,3]}'>FooBaz</b>, but this is incorrect because the attributes on the second <b> are dropped. Dropping those attributes leads to round-trip errors when those attributes are meaningful. https://gerrit.wikimedia.org/r/67493 addresses this in VE, but merging it would cause this to break.
Comment 1 Gabriel Wicke 2013-06-18 21:02:37 UTC

*** This bug has been marked as a duplicate of bug 42803 ***
Comment 2 Ed Sanders 2013-06-21 11:31:07 UTC

*** This bug has been marked as a duplicate of bug 48194 ***
Comment 3 Andre Klapper 2013-07-04 10:34:54 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links