Last modified: 2013-06-23 19:24:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51782, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49782 - Leading whitespace in transclusion invocation target does not round trip in parsoid.wmflabs.org
Leading whitespace in transclusion invocation target does not round trip in p...
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized minor
: ---
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-18 22:35 UTC by Krinkle
Modified: 2013-06-23 19:24 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-06-18 22:35:28 UTC
Looks like trailing whitespace does round trip.


* {{ {{ucfirst:{{lc:UNSIGNED}}}} |user=Root|date=00:43, 21 May 2013 (UTC)}}

->

* {{{{ucfirst:{{lc:UNSIGNED}}}} |user=Root|date=00:43, 21 May 2013 (UTC)}}
Comment 1 Roan Kattouw 2013-06-18 22:51:47 UTC
Are you sure this isn't a Parsoid bug? I've seen lots of template normalization issues to do with whitespace in Parsoid.
Comment 2 James Forrester 2013-06-21 20:45:13 UTC
Confirmed that this is an issue in Parsoid.
Comment 3 Gabriel Wicke 2013-06-21 20:48:53 UTC
If this template was modified, then normalizing the name should be fine.

If the template was not modified then this is likely a VE DOM round-tripping bug.
Comment 4 James Forrester 2013-06-21 21:52:07 UTC
Not a selser issue, this is Parsoid core issue; I'm OK with you WONTFIXing, but this is nothing to do with VE.
Comment 5 ssastry 2013-06-21 22:07:00 UTC
It is not a core issue.  editMode is true on parsoid.wmflabs.org -- so all serialization in forms go through regular serialization.

See below from commandline output:

[subbu@earth tests] echo '* {{ {{ucfirst:{{lc:UNSIGNED}}}} |user=Root|date=00:43, 21 May 2013 (UTC)}}' | node parse --wt2wt
* {{{{ucfirst:{{lc:UNSIGNED}}}} |user=Root|date=00:43, 21 May 2013 (UTC)}}
[subbu@earth tests] echo '* {{ {{ucfirst:{{lc:UNSIGNED}}}} |user=Root|date=00:43, 21 May 2013 (UTC)}}' | node parse --wt2wt --editMode false
* {{ {{ucfirst:{{lc:UNSIGNED}}}} |user=Root|date=00:43, 21 May 2013 (UTC)}}

So, this is going through non-selser serialization which means that segment of the DOM is being marked dirty.
Comment 6 ssastry 2013-06-21 22:09:05 UTC
That just brings up an unrelated issue.  Do we want editMode to be true / false on parsoid.wmflabs.org?  I offhand dont remember the reason why we defaulted it to true there.  Locally, my localsettings.js sets it to false.
Comment 7 Gabriel Wicke 2013-06-21 22:42:10 UTC
I think that it should always be true, except in rt testing. That installation mainly serves ourselves, and seeing a fully serialized template including the minor diffs is useful in that context.

Moving to VE again as the issue is most likely selser being disabled for the transclusion due to VE DOM modifications. Please test DOM round-tripping for this transclusion in VE.
Comment 8 Gabriel Wicke 2013-06-21 22:47:37 UTC
Timo, can you clarify if this transclusion was modified by the user?
Comment 9 James Forrester 2013-06-23 19:24:06 UTC
AFAICT this is an INVALID bug; marking as such. Timo, feel free to re-open if you can give context.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links