Last modified: 2013-06-19 22:38:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51785, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49785 - OpenStackManager API modules not requiring tokens
OpenStackManager API modules not requiring tokens
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenStackManager (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Ryan Lane
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-18 23:31 UTC by Alex Monk
Modified: 2013-06-19 22:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Require tokens for api calls in OSM (2.91 KB, patch)
2013-06-19 21:03 UTC, Ryan Lane 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Alex Monk 2013-06-18 23:31:29 UTC 
I noticed when reviewing Gerrit change #65557 that the ApiNovaInstance module in OpenStackManager does not require tokens. It looks like ApiNovaAddress should as well.
Comment 1 Alex Monk 2013-06-19 18:15:18 UTC 
I think the special pages need them as well.
Comment 2 Ryan Lane 2013-06-19 19:43:19 UTC 
The special pages use HTMLForm, which handles CSRF protection.
Comment 3 Ryan Lane 2013-06-19 21:03:24 UTC 
Created attachment 12588 [details]
Require tokens for api calls in OSM
Comment 4 Ryan Lane 2013-06-19 21:03:42 UTC 
Attached patch fixes the issue and is already deployed.
Comment 5 Alex Monk 2013-06-19 21:40:47 UTC 
Comment on attachment 12588 [details]
Require tokens for api calls in OSM

Works, just needs parameter description.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links