Last modified: 2013-06-19 12:47:04 UTC
jslint stopped running on Parsoid gerrit patches since sometime yesterday (June 18th) morning. https://gerrit.wikimedia.org/r/#/c/69437/ (no jslint) vs https://gerrit.wikimedia.org/r/#/c/69254/ (jslint)
The last build of mwext-Parsoid-jslint has been completed on June 17th 22:58:27 UTC. That points to a Zuul configuration change https://gerrit.wikimedia.org/r/#/c/69260/ merged a minute before. The regex has been changed: - - '^.*\.js$' + - '\.(js|json|jshint.*)$' The reason is Zuul use re.match() which look for a match at the beginning of the string (this is different from re.search() that looks anywhere: http://docs.python.org/2/library/re.html#search-vs-match ). Thus the regex would match a file named .js .json or .jshint* , not the expectation. I am reverting the patch and will submit a new regex.
Reverted in https://gerrit.wikimedia.org/r/#/c/69485/
Related URL: https://gerrit.wikimedia.org/r/69486 (Gerrit Change I6b1120c1b8c382ba4d64186efad363c47052a7c9)
a 'recheck' on parsoid change https://gerrit.wikimedia.org/r/69477 does trigger the jslint. On mediawiki/core https://gerrit.wikimedia.org/r/#/c/69487/ - change to .jshintrc triggers the jslint job - addition of a single js file 'foobar.js' triggers it to
