Last modified: 2013-07-04 10:33:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51849, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 49849 - Images: Image insertion uses both the English and the localised syntax for "right"


Summary:	Images: Image insertion uses both the English and the localised syntax for "r...

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-06-20 01:12 UTC by James Forrester
Modified:	2013-07-04 10:33 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-06-20 01:12:52 UTC

Reported initially in bug 49596:

ptwiki ("direita,right"): https://pt.wikipedia.org/w/index.php?&diff=36119075

plwiki ("prawo,right"): https://pl.wikipedia.org/w/index.php?diff=36790309

This feels like a Parsoid issue (VisualEditor doesn't know about localisations of these terms :-)) but Inez can tell us more details.

Comment 1 Inez Korczyński 2013-06-20 03:42:25 UTC

Correct - it is a Parsoid bug. Somehow it is similar to https://bugzilla.wikimedia.org/show_bug.cgi?id=48665 but definitely not a duplicate.

Comment 2 tm112 2013-06-20 05:21:26 UTC

It's not a
 (localised 'thumb'),right
this is
 (localised 'right'),right
as I mentioned in bug 49596 comment 6.

Comment 3 tm112 2013-06-20 05:22:47 UTC

(I also mentioned "/ramka/ means /frame/" but I suppose "ramka" would be localised "thumb"…?)

Comment 4 Bartosz Dziewoński 2013-06-20 07:48:32 UTC

These magic words are translateable at (for example for Polish) http://translatewiki.net/w/i.php?language=pl&module=words&title=Special%3AAdvancedTranslate - the entry for "right" says "prawo, right", which means both "prawo" and "right" are accepted and mean the canonical "right".

This looks as if Parsoid was calling (implicitly?) .toString() on an array of these terms instead of taking its first entry: ['prawo', 'right'].toString() == 'prawo,right'.

Comment 5 Helder 2013-06-21 11:51:13 UTC

AFAIC, there is nothing wrong in using the localized version. The problem is to use both.

Comment 6 Gerrit Notification Bot 2013-06-24 22:57:00 UTC

Related URL: https://gerrit.wikimedia.org/r/70343 (Gerrit Change I9717e9d4b3b79cc9e583fb74e3537fbb5112a7bf)

Comment 7 Gerrit Notification Bot 2013-06-24 23:18:00 UTC

https://gerrit.wikimedia.org/r/70343 (Gerrit Change I9717e9d4b3b79cc9e583fb74e3537fbb5112a7bf) | change APPROVED and MERGED [by jenkins-bot]

Comment 8 Andre Klapper 2013-07-04 10:33:36 UTC

[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links