Last modified: 2013-06-23 17:07:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51901, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49901 - Parsoid should have template parameter key/value whitespace of " = " not "="
Parsoid should have template parameter key/value whitespace of " = " not "="
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-06-20
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-20 18:44 UTC by Guillaume Paumier
Modified: 2013-06-23 17:07 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Guillaume Paumier 2013-06-20 18:44:24 UTC
In edits like https://fr.wikipedia.org/w/index.php?diff=94100781 , the whitespaces between the equal sign of a template parameter and the value of that parameter are removed. This causes confusing diffs since the user didn't make that change.
Comment 1 Gabriel Wicke 2013-06-21 01:20:46 UTC
If the user edited the transclusion, then normalization of spaces is to be expected, as remembering every purely syntactical variation would add way too much complexity and slow down processing.

If the user did not touch the transclusion, then you should not see any diff in the template. If you are still seeing a diff, then it is pretty likely that this is a VisualEditor issue. There were some issues in the preservation of HTML for templates when passed through VisualEditor, which can cause the template to appear edited when we get the HTML back.
Comment 2 ssastry 2013-06-21 05:44:07 UTC
That said, we are considering changing the default for edited templates where we normalize to a single space around the '=' sign.  This will still affect other templates where there was no space around them before, but in general, the change might be a better default.

This will still not fix the problem when HTML isn't preserved (either due to Parsoid or VE bugs) in its original form (as noted by Gabriel).  But, changing the default whitespace around '=' for template transclusions should make this look a little better.
Comment 3 James Forrester 2013-06-23 17:07:09 UTC
This has now been done in Parsoid.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links