Last modified: 2013-07-01 17:21:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51911, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49911 - nav collapse missing in beta
nav collapse missing in beta
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on: 49906
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-20 21:35 UTC by Chris McMahon
Modified: 2013-07-01 17:21 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
nav expand/collapse triangles missing (96.79 KB, image/png)
2013-06-20 21:35 UTC, Chris McMahon
Details
search suggestions missing when typing a term (191.66 KB, image/png)
2013-06-20 21:35 UTC, Chris McMahon
Details

Description Chris McMahon 2013-06-20 21:35:04 UTC
Created attachment 12596 [details]
nav expand/collapse triangles missing

As of June 20 in beta labs the expand/collapse in the left navigation bar often does not appear, nor do search prompts.  See screen shots. 

I thought that this was related to https://bugzilla.wikimedia.org/show_bug.cgi?id=46513 but now I think I was wrong.
Comment 1 Chris McMahon 2013-06-20 21:35:52 UTC
Created attachment 12597 [details]
search suggestions missing when typing a term
Comment 2 Antoine "hashar" Musso (WMF) 2013-06-24 15:46:38 UTC
This is actually two bugs. The search part was broken because the lucene index was dead, I have restarted the service there ( /etc/init.d/lucene-search-2 restart ) and that fixed it up.

About the sidebar expansion, that seems to be a regression somewhere in our code. Either in Vector skin, the Vector extension or something even nastier.  On Safari 6.0.5 I do see them though.
Comment 3 Antoine "hashar" Musso (WMF) 2013-06-24 16:07:48 UTC
The collapsibleTabs javascript has been moved from Vector to MediaWiki core recently.

I found out that Vector in mediawiki/extensions.git has not been updated, the last commit is Date:   Fri Mar 29 22:32:03 2013 -0300 .  That is a known issue (bug 49906) and might be the cause of the problem.
Comment 4 Antoine "hashar" Musso (WMF) 2013-06-24 16:16:02 UTC
Vector is properly updating, false alarm.
Comment 5 Antoine "hashar" Musso (WMF) 2013-06-24 20:32:49 UTC
Rob pointed the copy of a JavaScript collapsibleTabs script from Vector to MediaWiki/core:

https://gerrit.wikimedia.org/r/#/c/55524/
Comment 6 Antoine "hashar" Musso (WMF) 2013-06-24 20:33:10 UTC
The vector change is https://gerrit.wikimedia.org/r/#/c/56711/
Comment 7 Antoine "hashar" Musso (WMF) 2013-06-24 20:55:13 UTC
MatmaRex highlighted a similar issue happening on the production plwikisource . Sam had to clear /* cache key: plwikisource:resourceloader:filter:minify-js:7:4f71a68f01c144d82798d7c8c82ba20b */
Comment 8 Antoine "hashar" Musso (WMF) 2013-06-24 21:26:14 UTC
So in core, skins.vector.js had its dependencies changed: https://gerrit.wikimedia.org/r/#/c/55524/13/resources/Resources.php  Maybe that does not properly invalidate the cache key.
Comment 9 Antoine "hashar" Musso (WMF) 2013-06-24 21:53:53 UTC
Timo confirmed that if the content does not change, the minify output does not need a new cache key since the minified result will be fine.  Dependencies are not involved there.

MatmaRex pointed that the beta error is about jquery.delayedBind not being available, that is a new dependency to the module.  Seems like it did not trigger an invalidation of the module :(  That would be a bug in the resourceloader.
Comment 10 Antoine "hashar" Musso (WMF) 2013-06-24 22:07:28 UTC
I have restarted both memcached instance, purged all the load.php URLs but that is still the same issue.   I have exactly zero clue now about what might be wrong :(
Comment 11 Andre Klapper 2013-06-25 10:15:40 UTC
I could reproduce this in FF18 not being logged in. After logging in this still happened, appending &useskin=vector to the URL does not show the problem, and now reloading http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page (and bypassing cache) does not trigger the issue anymore either.

Going to http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page in Google Chrome 27 or Opera 12.15 for the very first time (not being logged in), I cannot reproduce the issue either anymore.
Comment 12 Chris McMahon 2013-06-25 20:52:22 UTC
Not being logged in seems to be important to reproduce this.
Comment 13 Antoine "hashar" Musso (WMF) 2013-06-26 09:21:33 UTC
The Javascript was not properly purged from the cache.  The resource loader material, loaded with load.php, is cached on the text squid, so I pruned the cache using:

 ssh deployment-squid.pmtpa.wmflabs
 sudo -s
 /etc/init.d/squid stop
 cd /mnt/squid_cache
 rm -r *
 squid -z
 /etc/init.d/squid start

With a cold cache, the load.php were queried again and loaded with the proper javascript.


The load.php should be loaded from the bits cache, that needs to adjust $wgLoadScript in MediaWiki which is https://gerrit.wikimedia.org/r/#/c/70322/


So the issue is fixed. The root cause are stalled URLs in the squid cache  :/
Comment 14 Chris McMahon 2013-06-26 14:16:05 UTC
Thanks very much for fixing this! 

Is there a risk of this happening in the same way in production as well as it did in beta labs?  I think the answer is "yes" but I am not sure.
Comment 15 Antoine "hashar" Musso (WMF) 2013-06-26 16:22:28 UTC
(In reply to comment #14)
> Thanks very much for fixing this! 
> 
> Is there a risk of this happening in the same way in production as well as it
> did in beta labs?  I think the answer is "yes" but I am not sure.

Yeah we talked about it with Sam. In production, caches are properly cleaned while deploying a new branch.

The issue happened on the production plwikisource iirc, some cache hasn't been properly purged on that wiki. Sam fixed it on sight.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links