Last modified: 2014-03-01 00:14:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51922, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49922 - VisualEditor: Transclusion editor "icon" can appear offscreen if the selected item starts offscreen
VisualEditor: Transclusion editor "icon" can appear offscreen if the selected...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: Editing team bugs – take if you're interested!
:
: 50907 51144 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-21 01:29 UTC by This, that and the other (TTO)
Modified: 2014-03-01 00:14 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description This, that and the other (TTO) 2013-06-21 01:29:50 UTC
1. Go to [[World War II]] and edit in VE
2. Scroll down to the Background section, and click on the infobox in order to select it

No puzzle-piece floating icon can be seen; you have to scroll up to the top of the template to see it.

This floating icon should always be visible on-screen.

(By the way, VE takes up to 4 seconds to "highlight" the infobox in response to the click; separate bug?)
Comment 1 James Forrester 2013-06-24 03:04:14 UTC
(In reply to comment #0)
> (By the way, VE takes up to 4 seconds to "highlight" the infobox in response
> to the click; separate bug?)

I saw the slowness too; distinct bug would be good, yes. Do you have any particular examples?
Comment 2 This, that and the other (TTO) 2013-06-24 04:32:24 UTC
(In reply to comment #1)
> I saw the slowness too; distinct bug would be good, yes.

See bug 50084.
Comment 3 James Forrester 2013-07-16 14:30:34 UTC
*** Bug 51144 has been marked as a duplicate of this bug. ***
Comment 4 Derk-Jan Hartman 2013-08-05 15:40:35 UTC
*** Bug 50907 has been marked as a duplicate of this bug. ***
Comment 5 Derk-Jan Hartman 2013-08-05 15:59:09 UTC
Note though that the problem can occur both horizontal as well as vertical.

Take for instance any template that produces a div, but of which the contents are not 100% wide. Examples of this are any div that is not cleared of a floating object.

The editor indicator is positioned all the way to the right of the div, which extends on top of the floating object. However the contents of the div are pushed aside by the floating object. You expect to find the template editor indicator at the right side of your contents, but you will find it superimposed on top of the infobox.

Similar for FA icons which are 10px wide in a div (and mispositioned due to their relative positioning which is currently not compatible with the editor). The Editor will be all the way to the right (think 27" display) whereas the actual visual content that you want to edit is all the way to the left in your screen.

(This is aggravated by the fact that VE duplicates the DOM, and thus causes duplicate id's, which are ignored by the style selectors in WebKit). This has some interesting consequences for all JS code btw. Even with hooks most of the scripts will break on this I presume.
Comment 6 Gerrit Notification Bot 2013-09-10 00:55:58 UTC
Change 74566 had a related patch set uploaded by Jforrester:
Scroll into view support

https://gerrit.wikimedia.org/r/74566
Comment 7 James Forrester 2013-09-19 06:09:53 UTC
Above patch didn't impact this; un-marking as having a PATCH.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links