Last modified: 2013-11-12 20:37:58 UTC
See screenshot, which is of https://en.wikipedia.org/wiki/Craig_Short - Firefox 21.0, Windows 7.
Created attachment 12608 [details] not displaying properly
Created attachment 12609 [details] not displaying properly
I don't think I can see your attachment, Oliver, but I think the bug may have to do with to these sshots, which both refer to adding a link: in the first one, the recycle bin can barely be seen as it gets hidden, the second one shows the link icon not being displayed as a square. Looks like this can happen both with Chrome and Firefox.
I thinks it depends on the skin: Monobook might be causing this.
Created attachment 12612 [details] what the template should look like (read mode)
Created attachment 12613 [details] what the template does look like (once in VE)
Created attachment 12614 [details] what the template does look like when selected
(In reply to comment #4) > I thinks it depends on the skin: Monobook might be causing this. That's a different bug - created bug 50057. This is about CE's rendering of floated templates - I've attached some example screenshots to demonstrate.
Created attachment 12673 [details] Screenshot This is likely a blocker for any beta rollout on Monday. I've attached a screenshot to show how bad it can get, and why :/.
For some reason wrapper in which we put transclusions/templates gets HTML attributes of the transclusion/template carried over - including CSS classes - that should not happen, and wasn't happening in the past. I will investigate it, however adding Roan to this ticket, it seems like it is his area.
+another example: https://en.wikipedia.org/wiki/Aranath?veaction=edit
*** Bug 50381 has been marked as a duplicate of this bug. ***
Change 71109 had a related patch set uploaded by Jforrester: Set renderHtmlAttributes to false, for both block and inline transclusions https://gerrit.wikimedia.org/r/71109
Change 71109 merged by jenkins-bot: Stop floated transclusions floating out of themselves https://gerrit.wikimedia.org/r/71109
The above patch fixes this bug, we believe. Marking as such.
*** Bug 50416 has been marked as a duplicate of this bug. ***
Created attachment 12695 [details] Crud It doesn't :(. See new screenshot.
Unless the patch hasn't been deployed yet, I guess.
(In reply to comment #18) > Unless the patch hasn't been deployed yet, I guess. It hasn't. Deployed on Monday alongside the config change. Not sure if the example in comment 17 will be entirely fixed by it though - please check after release?
Shall do.
Follow up: https://en.wikipedia.org/wiki/Leo_Strauss?veaction=edit is still screwed up.
