Last modified: 2013-07-25 17:00:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51931, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49931 - VisualEditor: Links not doing pre-annotations ever (rather than just not spanning on ' ') is confusing for users
VisualEditor: Links not doing pre-annotations ever (rather than just not span...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-25
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-21 05:41 UTC by This, that and the other (TTO)
Modified: 2013-07-25 17:00 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description This, that and the other (TTO) 2013-06-21 05:41:18 UTC
1. Go to [[mw:VisualEditor:TTO]] and edit in VE
2. Double-click on a link in order to select it, or drag-select the whole link
3. Type a new link text

Only the first character you type remains linked, instead of the whole text you type.
Comment 1 Michiel de Roo 2013-07-03 12:01:07 UTC
A related problem is, when you change only the first character of a link, that first letter is no longer part of the link. For example, if you change [[edinburgh]] to [[Edinburgh]], it becomes E[[dinburgh]].
Comment 2 James Forrester 2013-07-07 00:08:28 UTC
I agree that this behaviour is not great for users; we should reverse the decision to abandon "pre-annotation" (that is, if you're typing, we'll apply the same formatting as the character immediately before the one you've just typed in the same paragraph) for links.

Our concern was that having links always extent would be more tiresome for editors, which I still agree with, and that extending but not over whitespace would be confusing, which I think is arguable, but the current behaviour is worse.
Comment 3 Gerrit Notification Bot 2013-07-15 23:38:29 UTC
Change 73902 had a related patch set uploaded by Catrope:
Continue links

https://gerrit.wikimedia.org/r/73902
Comment 4 Gerrit Notification Bot 2013-07-16 00:31:56 UTC
Change 73902 merged by jenkins-bot:
Continue links

https://gerrit.wikimedia.org/r/73902
Comment 5 Ed Sanders 2013-07-16 16:28:40 UTC
That's all well and good, but now if my document ends in a link (a common case if I link the last thing I typed) I can't put plain text after it, which is the very reason we disabled trailing annotations for links in the first place...
Comment 6 James Forrester 2013-07-16 16:35:27 UTC
(In reply to comment #5)
> That's all well and good, but now if my document ends in a link (a common
> case if I link the last thing I typed) I can't put plain text after it, which
> is the very reason we disabled trailing annotations for links in the first
> place...

You can - you just need to press the "clear annotations" button, or press return to get a new context with no pre-annotations. However, yes, these suck for discoverability. I think not-extending-over-whitespace is the best solution, though it's fiddly and difficult to support.
Comment 7 Ed Sanders 2013-07-16 19:11:52 UTC
See bug 51463
Comment 8 James Forrester 2013-07-25 17:00:07 UTC
With bug 51463 closed, this is now complete. Marking as fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links